[Icons NTP] Refactor large_icon_source to extract the logic shared between desktop and Android to f…

chrome/browser/ui/webui/large_icon_source.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_LARGE_ICON_SOURCE_H_
 #define CHROME_BROWSER_UI_WEBUI_LARGE_ICON_SOURCE_H_
 
 #include <string>
 #include <vector>

[huangs, 2015/04/17 03:55:17]

Can move #include <vector> to the .cc file.

[beaudoin, 2015/04/17 14:50:52]

Done.

 
 #include "base/memory/scoped_ptr.h"
 #include "base/task/cancelable_task_tracker.h"
 #include "components/favicon/core/fallback_icon_service.h"
 #include "components/favicon_base/favicon_types.h"
 #include "content/public/browser/url_data_source.h"
 #include "third_party/skia/include/core/SkColor.h"
 
 namespace favicon {
 class FallbackIconService;
@@ skipping 43 matching lines @@
 
     content::URLDataSource::GotDataCallback callback;
     GURL url;
     int size;
   };
 
  private:
   // Callback for icon data retrieval request.
   void OnIconDataAvailable(
       const IconRequest& request,
-      const favicon_base::FaviconRawBitmapResult& bitmap_result);
+      const favicon_base::LargeIconResult& bitmap_result);
 
   // Renders and sends a default fallback icon. This is used when there is no
   // known text and/or foreground color to use for the generated icon (it
   // defaults to a light text color on a dark gray background).
   void SendDefaultFallbackIcon(const IconRequest& request);
 
   // Renders and sends a fallback icon using the given colors.
   void SendFallbackIcon(const IconRequest& request,
                         SkColor text_color,
                         SkColor background_color);
 
   // Returns null to trigger "Not Found" response.
   void SendNotFoundResponse(
       const content::URLDataSource::GotDataCallback& callback);
 
   base::CancelableTaskTracker cancelable_task_tracker_;
 
   favicon::FaviconService* favicon_service_;
 
   favicon::FallbackIconService* fallback_icon_service_;
 
-  // A pre-populated list of the types of icon files to consider when looking
-  // for the largest matching icon.
-  // Note: this is simply an optimization over populating an icon type vector
-  //     on each request.
-  std::vector<int> large_icon_types_;
-
   DISALLOW_COPY_AND_ASSIGN(LargeIconSource);
 };
 
 #endif  // CHROME_BROWSER_UI_WEBUI_LARGE_ICON_SOURCE_H_