Add support for parsing a 'partition' attribute on the <browser> tag.

content/renderer/browser_plugin/browser_plugin.h

Index: content/renderer/browser_plugin/browser_plugin.h
diff --git a/content/renderer/browser_plugin/browser_plugin.h b/content/renderer/browser_plugin/browser_plugin.h
index 210774b25f4831e1525a63833aedbed87601209c..cd910e46d0f2baa0839aa7aa96a931fa59f1f98e 100644
--- a/content/renderer/browser_plugin/browser_plugin.h
+++ b/content/renderer/browser_plugin/browser_plugin.h
@@ -32,6 +32,10 @@ class CONTENT_EXPORT BrowserPlugin :
   // Set the src attribute value of the BrowserPlugin instance and reset
   // the guest_crashed_ flag.
   void SetSrcAttribute(const std::string& src);
+  // The partition idetifier string is stored as UTF-8.

[Charlie Reis, 2012/09/18 22:09:33]

nit: identifier

[nasko, 2012/09/18 22:56:20]

Done.

+  std::string GetPartitionAttribute() const;
+  bool SetPartitionAttribute(const std::string& partition_id,
+                             std::string& error_message);

[Charlie Reis, 2012/09/18 22:09:33]

Please add a comment about |error_message|.  Also, this would be a good place to
mention that this can only be called before the first navigation takes place.

[nasko, 2012/09/18 22:56:20]

Done.

 
   // Inform the BrowserPlugin to update its backing store with the pixels in
   // its damage buffer.
@@ -116,10 +120,9 @@ class CONTENT_EXPORT BrowserPlugin :
   // Virtual to allow for mocking in tests.
   virtual float GetDeviceScaleFactor() const;
 
-  // Parses the source URL of the browser plugin from the element's attributes
-  // and outputs them.
-  bool ParseSrcAttribute(const WebKit::WebPluginParams& params,
-                         std::string* src);
+  // Parses the attributes of the browser plugin from the element's attributes
+  // and sets them appropriately.
+  void ParseAttributes(const WebKit::WebPluginParams& params);
 
   // Cleanup event listener state to free v8 resources when a BrowserPlugin
   // is destroyed.
@@ -138,6 +141,9 @@ class CONTENT_EXPORT BrowserPlugin :
   bool resize_pending_;
   long long parent_frame_;
   std::string src_;
+  bool has_navigated_;

[Charlie Reis, 2012/09/18 22:09:33]

FYI: This will end up being redundant with navigate_src_sent_ from the upcoming
larger browser plugin CL (http://codereview.chromium.org/10868012/).  We should
probably remove this once that lands.

[nasko, 2012/09/18 22:56:20]

Done.

+  std::string storage_partition_id_;
+  bool persist_storage_;
   typedef std::vector<v8::Persistent<v8::Function> > EventListeners;
   typedef std::map<std::string, EventListeners> EventListenerMap;
   EventListenerMap event_listener_map_;