Add support for parsing a 'partition' attribute on the <browser> tag.

content/renderer/browser_plugin/browser_plugin.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef  CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_H_
 #define  CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_H_
 
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebPlugin.h"
 
 #include "base/memory/scoped_ptr.h"
@@ skipping 14 matching lines @@
  public:
   // Called only by tests to clean up before we blow away the MockRenderProcess.
   void Cleanup();
 
   // Get the src attribute value of the BrowserPlugin instance if the guest
   // has not crashed.
   std::string GetSrcAttribute() const;
   // Set the src attribute value of the BrowserPlugin instance and reset
   // the guest_crashed_ flag.
   void SetSrcAttribute(const std::string& src);
+  // The partition idetifier string is stored as UTF-8.

[Charlie Reis, 2012/09/18 22:09:33]

nit: identifier

[nasko, 2012/09/18 22:56:20]

Done.

+  std::string GetPartitionAttribute() const;
+  bool SetPartitionAttribute(const std::string& partition_id,
+                             std::string& error_message);

[Charlie Reis, 2012/09/18 22:09:33]

Please add a comment about |error_message|.  Also, this would be a good place to
mention that this can only be called before the first navigation takes place.

[nasko, 2012/09/18 22:56:20]

Done.

 
   // Inform the BrowserPlugin to update its backing store with the pixels in
   // its damage buffer.
   void UpdateRect(int message_id,
                   const BrowserPluginMsg_UpdateRect_Params& params);
   // Inform the BrowserPlugin that its guest has crashed.
   void GuestCrashed();
   // Informs the BrowserPlugin that the guest has navigated to a new URL.
   void DidNavigate(const GURL& url);
   // Tells the BrowserPlugin to advance the focus to the next (or previous)
@@ skipping 64 matching lines @@
       const WebKit::WebPluginParams& params);
 
   virtual ~BrowserPlugin();
 
   int width() const { return plugin_rect_.width(); }
   int height() const { return plugin_rect_.height(); }
 
   // Virtual to allow for mocking in tests.
   virtual float GetDeviceScaleFactor() const;
 
-  // Parses the source URL of the browser plugin from the element's attributes
-  // and outputs them.
-  bool ParseSrcAttribute(const WebKit::WebPluginParams& params,
-                         std::string* src);
+  // Parses the attributes of the browser plugin from the element's attributes
+  // and sets them appropriately.
+  void ParseAttributes(const WebKit::WebPluginParams& params);
 
   // Cleanup event listener state to free v8 resources when a BrowserPlugin
   // is destroyed.
   void RemoveEventListeners();
 
   int instance_id_;
   RenderViewImpl* render_view_;
   WebKit::WebPluginContainer* container_;
   scoped_ptr<BrowserPluginBindings> bindings_;
   scoped_ptr<BrowserPluginBackingStore> backing_store_;
   TransportDIB* damage_buffer_;
   gfx::Rect plugin_rect_;
   // Bitmap for crashed plugin. Lazily initialized, non-owning pointer.
   SkBitmap* sad_guest_;
   bool guest_crashed_;
   bool resize_pending_;
   long long parent_frame_;
   std::string src_;
+  bool has_navigated_;

[Charlie Reis, 2012/09/18 22:09:33]

FYI: This will end up being redundant with navigate_src_sent_ from the upcoming
larger browser plugin CL (http://codereview.chromium.org/10868012/).  We should
probably remove this once that lands.

[nasko, 2012/09/18 22:56:20]

Done.

+  std::string storage_partition_id_;
+  bool persist_storage_;
   typedef std::vector<v8::Persistent<v8::Function> > EventListeners;
   typedef std::map<std::string, EventListeners> EventListenerMap;
   EventListenerMap event_listener_map_;
   DISALLOW_COPY_AND_ASSIGN(BrowserPlugin);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_H_