Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 10928221: Add a missing dependency from app_host to chrome_version_resources (Closed)

Created:
8 years, 3 months ago by Nico
Modified:
8 years, 3 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, M-A Ruel
Visibility:
Public.

Description

Add a missing dependency from app_host to chrome_version_resources app_host uses app_host_exe_version.rc, but doesn't depend on the target that creates it. It looks like MSVS isn't smart enough to figure out this dependency itself. BUG=none TEST=No 'win' bot fails on compile in mac-only cls TBR=huangs

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/chrome_browser_extensions.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
8 years, 3 months ago (2012-09-15 22:54:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10928221/1
8 years, 3 months ago (2012-09-15 22:54:20 UTC) #2
commit-bot: I haz the power
Failed to apply patch for chrome/chrome_browser_extensions.gypi: While running patch -p1 --forward --force; patching file chrome/chrome_browser_extensions.gypi ...
8 years, 3 months ago (2012-09-15 22:54:21 UTC) #3
Nico
Looks like erikwright fixed this in https://chromiumcodereview.appspot.com/10914296 . (Erik, when you land fixes that unbreak ...
8 years, 3 months ago (2012-09-15 23:04:03 UTC) #4
erikwright (departed)
8 years, 3 months ago (2012-09-15 23:23:49 UTC) #5
I didn't know the CQ was broken. I just realized the fix was needed. I
submitted it NOTRY=True which should be basically the same as submitting
directly except waiting for the tree to be green.

Sorry for any trouble caused.

On Sat, Sep 15, 2012 at 7:04 PM, <thakis@chromium.org> wrote:

> Looks like erikwright fixed this in
>
https://chromiumcodereview.**appspot.com/10914296<https://chromiumcodereview.....
(Erik, when you land fixes
> that unbreak the cq, please land them directly. It looks like the cq was
> broken
> needlessly for one day due to your fix being stuck there)
>
>
https://codereview.chromium.**org/10928221/<https://codereview.chromium.org/1...
>

Powered by Google App Engine
This is Rietveld 408576698