Cleanup after componentization of //chrome/browser/undo

Cleanup after componentization of //chrome/browser/undo

Remove temporary OWNERS rights for sdefresne as the componentization is
complete.

Re-order the deps of //components/undo/BUILD.gn to follow best
practices.

BUG=476917
Committed: https://crrev.com/e936869562e01bd1f1d36797641922d9753e580f
Cr-Commit-Position: refs/heads/master@{#325848}

[sdefresne, 2015-04-20 13:07:41]

sdefresne@chromium.org changed reviewers:
+ droger@chromium.org, tfarina@chromium.org

[sdefresne, 2015-04-20 13:07:42]

PTAL

[tfarina, 2015-04-20 13:10:50]

lgtm

https://codereview.chromium.org/1092813005/diff/1/components/undo/BUILD.gn
File components/undo/BUILD.gn (right):

https://codereview.chromium.org/1092813005/diff/1/components/undo/BUILD.gn#ne...
components/undo/BUILD.gn:5: static_library("undo") {
just curious (I haven't look), have you run this through 'gn check', just to
make sure we got all the dependencies and didn't miss any?

Something like:

$ gn gen out-gn
$ gn check out-gn //components/undo/*

https://codereview.chromium.org/1092813005/diff/1/components/undo/BUILD.gn#ne...
components/undo/BUILD.gn:35: ":undo",
yep, thanks.

[sdefresne, 2015-04-20 13:13:29]

Thank you for the review.

https://codereview.chromium.org/1092813005/diff/1/components/undo/BUILD.gn
File components/undo/BUILD.gn (right):

https://codereview.chromium.org/1092813005/diff/1/components/undo/BUILD.gn#ne...
components/undo/BUILD.gn:5: static_library("undo") {
On 2015/04/20 13:10:50, tfarina wrote:
> just curious (I haven't look), have you run this through 'gn check', just to
> make sure we got all the dependencies and didn't miss any?
> 
> Something like:
> 
> $ gn gen out-gn
> $ gn check out-gn //components/undo/*

I had not, but I just did, and no error is reported:

$ gn check out/Default //components/undo
Header dependency check OK
$

https://codereview.chromium.org/1092813005/diff/1/components/undo/BUILD.gn#ne...
components/undo/BUILD.gn:35: ":undo",
On 2015/04/20 13:10:50, tfarina wrote:
> yep, thanks.

Acknowledged.

[droger, 2015-04-20 13:39:30]

LGTM

good job for the componentization.

[sdefresne, 2015-04-20 13:51:28]

Thank you for the review.

[sdefresne, 2015-04-20 13:51:33]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2015-04-20 13:51:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1092813005/1

[commit-bot: I haz the power, 2015-04-20 13:59:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-20 13:59:32]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sdefresne, 2015-04-20 14:22:40]

sdefresne@chromium.org changed reviewers:
+ sky@chromium.org

[sdefresne, 2015-04-20 14:22:40]

sky: OWNERS review

[sky, 2015-04-20 15:28:22]

LGTM

[sdefresne, 2015-04-20 15:33:35]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2015-04-20 15:34:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1092813005/1

[commit-bot: I haz the power, 2015-04-20 15:39:06]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-04-20 15:40:04]

Patchset 1 (id:??) landed as
https://crrev.com/e936869562e01bd1f1d36797641922d9753e580f
Cr-Commit-Position: refs/heads/master@{#325848}