Cleanup after componentization of //chrome/browser/undo

components/undo/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 static_library("undo") {

[tfarina, 2015/04/20 13:10:50]

just curious (I haven't look), have you run this through 'gn check', just to
make sure we got all the dependencies and didn't miss any?

Something like:

$ gn gen out-gn
$ gn check out-gn //components/undo/*

[sdefresne, 2015/04/20 13:13:29]

I had not, but I just did, and no error is reported:

$ gn check out/Default //components/undo
Header dependency check OK
$

   sources = [
     "bookmark_renumber_observer.h",
     "bookmark_undo_service.cc",
     "bookmark_undo_service.h",
     "bookmark_undo_utils.cc",
     "bookmark_undo_utils.h",
     "undo_manager.cc",
     "undo_manager.h",
     "undo_manager_observer.h",
     "undo_operation.h",
   ]
 
   deps = [
     "//base",
     "//components/bookmarks/browser",
     "//components/keyed_service/core",
     "//components/strings",
     "//ui/base",
   ]
 }
 
 source_set("unit_tests") {
   testonly = true
   sources = [
     "bookmark_undo_service_test.cc",
     "undo_manager_test.cc",
   ]
 
   deps = [
+    ":undo",

[tfarina, 2015/04/20 13:10:50]

yep, thanks.

[sdefresne, 2015/04/20 13:13:29]

Acknowledged.

     "//components/bookmarks/test",
     "//testing/gtest",
-    ":undo",
   ]
 }