Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 10928114: Allow running browser tests each in single-process mode. This is useful for Android team, which wan… (Closed)

Created:
8 years, 3 months ago by jam
Modified:
8 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Allow running browser tests each in single-process mode. This is useful for Android team, which want to run every test in content_browsertests in single-process mode. Browser tests need to run in separate processes though, each since browser initialization can't happen twice. Currently, if --single-process is specified, the second test run will assert because of the multiple browser-process initialization problem. This change makes it so that it works as expected. However, it will still fail as before if --single-process and --gtest_filter=<multiple_tests> is passed. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156107

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M content/public/test/test_launcher.cc View 2 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
8 years, 3 months ago (2012-09-11 16:46:01 UTC) #1
sky
8 years, 3 months ago (2012-09-11 17:39:47 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698