Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1615)

Unified Diff: content/public/test/test_launcher.cc

Issue 10928114: Allow running browser tests each in single-process mode. This is useful for Android team, which wan… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/test/test_launcher.cc
===================================================================
--- content/public/test/test_launcher.cc (revision 156015)
+++ content/public/test/test_launcher.cc (working copy)
@@ -697,12 +697,9 @@
return 0;
}
- // TODO(pkasting): This "single_process vs. single-process" design is
- // terrible UI. Instead, there should be some sort of signal flag on the
- // command line, with all subsequent arguments passed through to the
- // underlying browser.
if (command_line->HasSwitch(kSingleProcessTestsFlag) ||
- command_line->HasSwitch(kSingleProcessTestsAndChromeFlag) ||
+ (command_line->HasSwitch(kSingleProcessTestsAndChromeFlag) &&
+ command_line->HasSwitch(kGTestFilterFlag)) ||
command_line->HasSwitch(kGTestListTestsFlag) ||
command_line->HasSwitch(kGTestHelpFlag)) {
#if defined(OS_WIN)
@@ -729,8 +726,8 @@
"IMPORTANT DEBUGGING NOTE: each test is run inside its own process.\n"
"For debugging a test inside a debugger, use the\n"
"--gtest_filter=<your_test_name> flag along with either\n"
- "--single_process (to run all tests in one launcher/browser process) or\n"
- "--single-process (to do the above, and also run Chrome in single-\n"
+ "--single_process (to run the test in one launcher/browser process) or\n"
+ "--single-process (to do the above, and also run Chrome in single-"
"process mode).\n");
testing::InitGoogleTest(&argc, argv);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698