Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: webkit/tools/layout_tests/run_webkit_tests.py

Issue 10926: Place all new baseline files in the most specific platform directory.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/tools/layout_tests/run_webkit_tests.py
===================================================================
--- webkit/tools/layout_tests/run_webkit_tests.py (revision 5432)
+++ webkit/tools/layout_tests/run_webkit_tests.py (working copy)
@@ -230,12 +230,7 @@
test_args.png_path = png_path
test_args.wdiff = self._options.wdiff
-
- if self._options.new_baseline:
- test_args.new_baseline = self._options.new_baseline
- if not self._options.pixel_tests:
- test_args.text_baseline = True
-
+ test_args.new_baseline = self._options.new_baseline
test_args.show_sources = self._options.sources
# Create separate TestTypes instances for each thread.
@@ -513,6 +508,10 @@
logging.info("Using platform '%s'" % options.platform)
logging.info("Placing test results in %s" % options.results_directory)
+ if options.new_baseline:
+ logging.info("Placing new baselines in %s" %
+ os.path.join(path_utils.PlatformResultsDir(options.platform),
+ options.platform))
logging.info("Using %s build at %s" %
(options.target, test_shell_binary_path))
if options.pixel_tests:
@@ -566,12 +565,11 @@
default="layout-test-results",
help="Output results directory source dir,"
" relative to Debug or Release")
- option_parser.add_option("", "--new-baseline", default=None, metavar="DIR",
- help="save results as new baselines into this "
- "directory (e.g. layout_test_results/v8), "
- "overwriting whatever's already there. "
- "If pixel tests are being run, only image "
- "baselines will be saved, not text.")
+ option_parser.add_option("", "--new-baseline", action="store_true",
+ default=False,
+ help="save all generated results as new baselines "
+ "into the platform directory , overwriting "
tony 2008/11/14 04:45:42 Nit: space before comma.
+ "whatever's already there.")
option_parser.add_option("", "--noshow-results", action="store_true",
default=False, help="don't launch the test_shell"
" with results after the tests are done")

Powered by Google App Engine
This is Rietveld 408576698