Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issue 109223002: [webcrypto] Add crypto.subtle.wrapKey() and crypto.subtle.unwrapKey() (Closed)

Created:
7 years ago by eroman
Modified:
7 years ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium, padolph
Visibility:
Public.

Description

[webcrypto] Add crypto.subtle.wrapKey() and crypto.subtle.unwrapKey() As described by the WebCrypto spec: http://www.w3.org/TR/WebCryptoAPI/#dfn-SubtleCrypto-method-wrapKey http://www.w3.org/TR/WebCryptoAPI/#dfn-SubtleCrypto-method-unwrapKey In particular, this changelist introduces the javascript-side bindings. This includes the algorithm normalization, various checks on parameters like key usages and key extractability, and then defers the real cryptographic work to the embedder via two new methods on Blink API. BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163456

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : modify a comment for consistency #

Patch Set 4 : Rebase test expectations (to match latest changes I had made) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -2 lines) Patch
M LayoutTests/crypto/resources/common.js View 1 chunk +2 lines, -2 lines 0 comments Download
A LayoutTests/crypto/wrap-unwrap.html View 1 1 chunk +100 lines, -0 lines 0 comments Download
A LayoutTests/crypto/wrap-unwrap-expected.txt View 1 2 3 1 chunk +26 lines, -0 lines 0 comments Download
M Source/modules/crypto/Key.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/crypto/NormalizeAlgorithm.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M Source/modules/crypto/SubtleCrypto.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/modules/crypto/SubtleCrypto.cpp View 1 chunk +76 lines, -0 lines 0 comments Download
M Source/modules/crypto/SubtleCrypto.idl View 1 chunk +3 lines, -0 lines 0 comments Download
M public/platform/WebCrypto.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
eroman
7 years ago (2013-12-07 00:17:07 UTC) #1
abarth-chromium
lgtm
7 years ago (2013-12-07 22:05:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/109223002/60001
7 years ago (2013-12-09 19:01:53 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-09 21:07:29 UTC) #4
Message was sent while issue was closed.
Change committed as 163456

Powered by Google App Engine
This is Rietveld 408576698