Source/modules/crypto/Key.cpp - Issue 109223002: [webcrypto] Add crypto.subtle.wrapKey() and crypto.subtle.unwrapKey()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/crypto/Key.cpp

Issue 109223002: [webcrypto] Add crypto.subtle.wrapKey() and crypto.subtle.unwrapKey() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase test expectations (to match latest changes I had made) Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/crypto/Key.cpp

diff --git a/Source/modules/crypto/Key.cpp b/Source/modules/crypto/Key.cpp

index e9976e27ba6c4d94498e442846e895175a116cdf..d6e5cc40f01a4d6df2df218b01600a259be17560 100644

--- a/Source/modules/crypto/Key.cpp

+++ b/Source/modules/crypto/Key.cpp

@@ -189,6 +189,7 @@ bool Key::canBeUsedForAlgorithm(const blink::WebCryptoAlgorithm& algorithm, Algo

// Verify that the algorithm-specific parameters for the key conform to the

// algorithm.

+ // FIXME: Verify that this is complete.

if (m_key.algorithm().id() == blink::WebCryptoAlgorithmIdHmac) {

blink::WebCryptoAlgorithmId keyHash;