Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: chrome/browser/banners/app_banner_manager.h

Issue 1092193004: Use related_applications manifest fields when showing native app banners (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_manager.h
diff --git a/chrome/browser/banners/app_banner_manager.h b/chrome/browser/banners/app_banner_manager.h
index 020c559f3b6c4ce9b22b5541ac6abb5da9bf31f2..a84be6053512a13a9e486103c99699e249c6a007 100644
--- a/chrome/browser/banners/app_banner_manager.h
+++ b/chrome/browser/banners/app_banner_manager.h
@@ -43,9 +43,6 @@ class AppBannerManager : public content::WebContentsObserver,
void DidFinishLoad(content::RenderFrameHost* render_frame_host,
const GURL& validated_url) override;
- // AppBannerDataFetcher::Delegate overrides.
- bool OnInvalidManifest(AppBannerDataFetcher* fetcher) override;
-
protected:
void ReplaceWebContents(content::WebContents* web_contents);
@@ -61,6 +58,11 @@ class AppBannerManager : public content::WebContentsObserver,
int ideal_icon_size() { return ideal_icon_size_; }
private:
+ // AppBannerDataFetcher::Delegate overrides.
+ bool HandleNonWebApp(const std::string& platform,
+ const GURL& url,
+ const std::string& id) override;
+
// Called after the manager sends a message to the renderer regarding its
// intention to show a prompt. The renderer will send a message back with the
// opportunity to cancel.
« no previous file with comments | « chrome/browser/banners/app_banner_data_fetcher_unittest.cc ('k') | chrome/browser/banners/app_banner_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698