Issue 1092053002: Prevent analyze from filtering out crash_service target.

Issue 1092053002: Prevent analyze from filtering out crash_service target. (Closed)

Created:
5 years, 8 months ago by Adrian Kuegel

Modified:
5 years, 8 months ago

Reviewers:
Sergiy Byelozyorov

CC:
chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master

Target Ref:
refs/heads/master

Project:
tools

Visibility:
Public.

More Reviews

Description

Prevent analyze from filtering out crash_service target. This is meant as a stop-gap solution, and should be replaced by a better solution (see crbug.com/478053). BUG=472068 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294875

Patch Set 1 : Fix some issues. #

Total comments: 2

Patch Set 2 : Address nit. #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -8 lines)			Patch
M	scripts/slave/recipe_modules/chromium_tests/api.py	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_gn.expected/full_tryserver_chromium_win_win8_chromium_gn_dbg.json	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	scripts/slave/recipes/chromium_gn.expected/full_tryserver_chromium_win_win8_chromium_gn_rel.json	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/analyze_runs_only_angle_unittests.json	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/swarming_time_out_is_handled_correctly.json	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 10 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Sergiy Byelozyorov

lgtm w/ comments https://codereview.chromium.org/1092053002/diff/20001/scripts/slave/recipe_modules/chromium_tests/api.py File scripts/slave/recipe_modules/chromium_tests/api.py (right): https://codereview.chromium.org/1092053002/diff/20001/scripts/slave/recipe_modules/chromium_tests/api.py#newcode731 scripts/slave/recipe_modules/chromium_tests/api.py:731: # TODO(akuegel): Need to solve this ...

5 years, 8 months ago (2015-04-17 12:44:32 UTC) #4

Adrian Kuegel

https://codereview.chromium.org/1092053002/diff/20001/scripts/slave/recipe_modules/chromium_tests/api.py File scripts/slave/recipe_modules/chromium_tests/api.py (right): https://codereview.chromium.org/1092053002/diff/20001/scripts/slave/recipe_modules/chromium_tests/api.py#newcode731 scripts/slave/recipe_modules/chromium_tests/api.py:731: # TODO(akuegel): Need to solve this in a better ...

5 years, 8 months ago (2015-04-17 12:47:04 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092053002/40001

5 years, 8 months ago (2015-04-17 12:47:11 UTC) #8

commit-bot: I haz the power

Committed patchset #2 (id:40001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=294875

5 years, 8 months ago (2015-04-17 12:49:45 UTC) #9

Dirk Pranke

5 years, 8 months ago (2015-04-17 21:28:26 UTC) #10

Message was sent while issue was closed.

On 2015/04/17 12:49:45, I haz the power (commit-bot) wrote:
> Committed patchset #2 (id:40001) as
> http://src.chromium.org/viewvc/chrome?view=rev&revision=294875

This changes breaks the GN bots, which don't build crash_service on windows yet.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages