scripts/slave/recipes/chromium_gn.expected/full_tryserver_chromium_win_win8_chromium_gn_dbg.json - Issue 1092053002: Prevent analyze from filtering out crash_service target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_gn.expected/full_tryserver_chromium_win_win8_chromium_gn_dbg.json

Issue 1092053002: Prevent analyze from filtering out crash_service target. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Address nit. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/chromium_tests/api.py ('k') | scripts/slave/recipes/chromium_gn.expected/full_tryserver_chromium_win_win8_chromium_gn_rel.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium_gn.expected/full_tryserver_chromium_win_win8_chromium_gn_dbg.json

diff --git a/scripts/slave/recipes/chromium_gn.expected/full_tryserver_chromium_win_win8_chromium_gn_dbg.json b/scripts/slave/recipes/chromium_gn.expected/full_tryserver_chromium_win_win8_chromium_gn_dbg.json

index 0154e558212a181246863d02418b0b15c484d7a7..e19d43b3c2a9e2e5020b900ab96a780d1b4e46cb 100644

--- a/scripts/slave/recipes/chromium_gn.expected/full_tryserver_chromium_win_win8_chromium_gn_dbg.json

+++ b/scripts/slave/recipes/chromium_gn.expected/full_tryserver_chromium_win_win8_chromium_gn_dbg.json

@@ -186,7 +186,8 @@

"@@@STEP_LOG_END@json.output@@@",

"@@@STEP_LOG_LINE@analyze_details@{@@@",

"@@@STEP_LOG_LINE@analyze_details@ \"compile_targets\": [@@@",

- "@@@STEP_LOG_LINE@analyze_details@ \"base_unittests\"@@@",

+ "@@@STEP_LOG_LINE@analyze_details@ \"base_unittests\", @@@",

+ "@@@STEP_LOG_LINE@analyze_details@ \"crash_service\"@@@",

"@@@STEP_LOG_LINE@analyze_details@ ], @@@",

"@@@STEP_LOG_LINE@analyze_details@ \"original_compile_targets\": [@@@",

"@@@STEP_LOG_LINE@analyze_details@ \"base_unittests\"@@@",

@@ -221,7 +222,8 @@

"--goma-dir",

"[BUILD]\\goma",

"--",

- "base_unittests"

+ "base_unittests",

+ "crash_service"

"name": "compile"