Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1092033003: Pulls display related changes from mojo to chrome (Closed)

Created:
5 years, 8 months ago by sky
Modified:
5 years, 8 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pulls display related changes from mojo to chrome This gets the two close to back in sync. I'm TBRing as you reviewed most of these already, and those you didn't review have been reviewed by others. The guards are all wrong in these files. I'll fix that separately. TBR=erg@chromium.org R=erg@chromium.org Committed: https://crrev.com/6d2c9d9585a9184bb855dc3bbed81a25b3bf0dc8 Cr-Commit-Position: refs/heads/master@{#325716}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2304 lines, -435 lines) Patch
M mojo/services/native_viewport/android/src/org/chromium/mojo/PlatformViewportAndroid.java View 2 chunks +7 lines, -6 lines 0 comments Download
M mojo/services/native_viewport/platform_viewport_android.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/native_viewport/platform_viewport_android.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M mojo/services/view_manager/BUILD.gn View 3 chunks +16 lines, -0 lines 0 comments Download
M mojo/services/view_manager/connection_manager.h View 4 chunks +22 lines, -11 lines 0 comments Download
M mojo/services/view_manager/connection_manager.cc View 9 chunks +56 lines, -43 lines 0 comments Download
A mojo/services/view_manager/focus_controller.h View 1 chunk +53 lines, -0 lines 0 comments Download
A mojo/services/view_manager/focus_controller.cc View 1 chunk +54 lines, -0 lines 0 comments Download
A mojo/services/view_manager/focus_controller_delegate.h View 1 chunk +23 lines, -0 lines 0 comments Download
A mojo/services/view_manager/focus_controller_unittest.cc View 1 chunk +106 lines, -0 lines 0 comments Download
A mojo/services/view_manager/gesture_manager.h View 1 chunk +188 lines, -0 lines 0 comments Download
A mojo/services/view_manager/gesture_manager.cc View 1 chunk +701 lines, -0 lines 0 comments Download
A mojo/services/view_manager/gesture_manager_delegate.h View 1 chunk +31 lines, -0 lines 0 comments Download
A mojo/services/view_manager/gesture_manager_unittest.cc View 1 chunk +467 lines, -0 lines 0 comments Download
M mojo/services/view_manager/server_view.h View 4 chunks +11 lines, -0 lines 0 comments Download
M mojo/services/view_manager/server_view.cc View 10 chunks +40 lines, -12 lines 0 comments Download
M mojo/services/view_manager/server_view_delegate.h View 1 chunk +11 lines, -28 lines 0 comments Download
A mojo/services/view_manager/server_view_drawn_tracker.h View 1 chunk +58 lines, -0 lines 0 comments Download
A mojo/services/view_manager/server_view_drawn_tracker.cc View 1 chunk +76 lines, -0 lines 0 comments Download
A mojo/services/view_manager/server_view_drawn_tracker_observer.h View 1 chunk +28 lines, -0 lines 0 comments Download
A mojo/services/view_manager/server_view_drawn_tracker_unittest.cc View 1 chunk +136 lines, -0 lines 0 comments Download
A mojo/services/view_manager/server_view_observer.h View 1 chunk +63 lines, -0 lines 0 comments Download
M mojo/services/view_manager/test_server_view_delegate.h View 1 chunk +5 lines, -20 lines 0 comments Download
M mojo/services/view_manager/test_server_view_delegate.cc View 1 chunk +6 lines, -33 lines 0 comments Download
M mojo/services/view_manager/view_coordinate_conversions.h View 2 chunks +11 lines, -0 lines 0 comments Download
M mojo/services/view_manager/view_coordinate_conversions.cc View 1 chunk +37 lines, -10 lines 0 comments Download
M mojo/services/view_manager/view_coordinate_conversions_unittest.cc View 2 chunks +27 lines, -2 lines 0 comments Download
A mojo/services/view_manager/view_locator.h View 1 chunk +24 lines, -0 lines 0 comments Download
A mojo/services/view_manager/view_locator.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M mojo/services/view_manager/view_manager_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/window_manager/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D mojo/services/window_manager/window_manager_api_unittest.cc View 1 chunk +0 lines, -260 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
sky
5 years, 8 months ago (2015-04-17 20:45:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092033003/1
5 years, 8 months ago (2015-04-17 20:46:45 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-17 21:09:16 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6d2c9d9585a9184bb855dc3bbed81a25b3bf0dc8 Cr-Commit-Position: refs/heads/master@{#325716}
5 years, 8 months ago (2015-04-17 21:10:27 UTC) #5
Stephen Chennney
5 years, 8 months ago (2015-04-17 23:31:47 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1097803002/ by schenney@chromium.org.

The reason for reverting is: Seems to break the build all over the Blink tree.

.

Powered by Google App Engine
This is Rietveld 408576698