Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1091963002: Revert of Revert of remove unused (by clients) SkPathUtils (Closed)

Created:
5 years, 8 months ago by reed2
Modified:
5 years, 8 months ago
Reviewers:
scroggo, jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Revert of remove unused (by clients) SkPathUtils (patchset #1 id:1 of https://codereview.chromium.org/1060703003/) Reason for revert: fix (removal from gypi/gn files) has landed in chrome. Original issue's description: > Revert of remove unused (by clients) SkPathUtils (patchset #1 id:1 of https://codereview.chromium.org/1088383003/) > > Reason for revert: > This change is causing the DEPS roll to fail: > > > http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/78771/steps/gn/logs/stdio > > Original issue's description: > > remove unused (by clients) SkPathUtils > > > > BUG=skia: > > > > Committed: https://skia.googlesource.com/skia/+/aab35d91b8b80acd1902594bbf542083fdfa4bb7 > > TBR=scroggo@google.com,reed@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/bdb0bf5f8858043878d8a4fa8130c6c87bef3fd4 TBR=scroggo@google.com,jcgregorio@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/ca1a22ee534f0fcabed7fa06cbf3ea5068b489da

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -528 lines) Patch
D bench/PathUtilsBench.cpp View 1 chunk +0 lines, -72 lines 0 comments Download
M gyp/SampleApp.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/bench.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/utils.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D include/utils/SkPathUtils.h View 1 chunk +0 lines, -40 lines 0 comments Download
D samplecode/SamplePathUtils.cpp View 1 chunk +0 lines, -108 lines 0 comments Download
D src/utils/SkPathUtils.cpp View 1 chunk +0 lines, -152 lines 0 comments Download
D tests/PathUtilsTest.cpp View 1 chunk +0 lines, -152 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
reed2
Created Revert of Revert of remove unused (by clients) SkPathUtils
5 years, 8 months ago (2015-04-17 03:10:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1091963002/1
5 years, 8 months ago (2015-04-17 03:10:45 UTC) #2
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 03:10:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ca1a22ee534f0fcabed7fa06cbf3ea5068b489da

Powered by Google App Engine
This is Rietveld 408576698