Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 10919316: Address Peter's comments on the new parameter specification implementation. (Closed)

Created:
8 years, 3 months ago by ngeoffray
Modified:
8 years, 3 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Address Peter's comments on the new parameter specification implementation. Committed: https://code.google.com/p/dart/source/detail?r=12498

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -44 lines) Patch
M lib/compiler/implementation/js_backend/emitter.dart View 1 4 chunks +37 lines, -38 lines 0 comments Download
M lib/compiler/implementation/js_backend/namer.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M lib/compiler/implementation/js_backend/native_emitter.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/ssa/builder.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/universe/universe.dart View 1 4 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ngeoffray
8 years, 3 months ago (2012-09-17 12:20:40 UTC) #1
ahe
8 years, 3 months ago (2012-09-18 12:54:26 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698