Address Peter's comments on the new parameter specification implementation.

lib/compiler/implementation/universe/universe.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library('universe');
 
 #import('../closure.dart');
 #import('../elements/elements.dart');
 #import('../leg.dart');
 #import('../scanner/scannerlib.dart');
@@ skipping 189 matching lines @@
     if (isGetter()) return true;
 
     FunctionElement function = element;
     FunctionSignature parameters = function.computeSignature(compiler);
     if (argumentCount > parameters.parameterCount) return false;
     int requiredParameterCount = parameters.requiredParameterCount;
     int optionalParameterCount = parameters.optionalParameterCount;
     if (positionalArgumentCount < requiredParameterCount) return false;
 
     if (!parameters.optionalParametersAreNamed) {
+      // TODO(5074): Remove this check once we don't accept the
+      // deprecated parameter specification.
       if (!Compiler.REJECT_NAMED_ARGUMENT_AS_POSITIONAL) {
         return optionalParametersAppliesDEPRECATED(element, compiler);
       } else {
         // We have already checked that the number of arguments are
         // not greater than the number of parameters. Therefore the
         // number of positional arguments are not greater than the
         // number of parameters.
         assert(positionalArgumentCount <= parameters.parameterCount);
         return namedArguments.isEmpty();
       }
     } else {
       if (positionalArgumentCount > requiredParameterCount) return false;
+      assert(positionalArgumentCount == requiredParameterCount);
       if (namedArgumentCount > optionalParameterCount) return false;
       Set<SourceString> nameSet = new Set<SourceString>();
       parameters.optionalParameters.forEach((Element element) {
         nameSet.add(element.name);
       });
       for (SourceString name in namedArguments) {
         if (!nameSet.contains(name)) return false;
-        // TODO(ngeoffray): By removing from the set we are checking
+        // TODO(5213): By removing from the set we are checking
         // that we are not passing the name twice. We should have this
-        // check in the resolver instead.
+        // check in the resolver also.
         nameSet.remove(name);
       }
       return true;
     }
   }
 
   // TODO(5074): Remove this method once we don't accept the
   // deprecated parameter specification.
   bool optionalParametersAppliesDEPRECATED(FunctionElement function,
                                            Compiler compiler) {
@@ skipping 96 matching lines @@
                           Compiler compiler) {
     if (!this.applies(element, compiler)) return false;
 
     FunctionSignature parameters = element.computeSignature(compiler);
     parameters.forEachRequiredParameter((element) {
       list.add(compileArgument(arguments.head));
       arguments = arguments.tail;
     });
 
     if (!parameters.optionalParametersAreNamed) {
+      // TODO(5074): Remove this check once we don't accept the
+      // deprecated parameter specification.
       if (!Compiler.REJECT_NAMED_ARGUMENT_AS_POSITIONAL) {
         addOptionalArgumentsToListDEPRECATED(
             arguments, list, element, compileArgument, compileConstant,
             compiler);
       } else {
         parameters.forEachOptionalParameter((element) {
           if (!arguments.isEmpty()) {
             list.add(compileArgument(arguments.head));
             arguments = arguments.tail;
           } else {
@@ skipping 133 matching lines @@
 
     if (!self.isInterface() && self.isSubclassOf(other)) {
       // Resolve an invocation of [element.name] on [self]. If it
       // is found, this selector is a candidate.
       return hasElementIn(self, element) && appliesUntyped(element, compiler);
     }
 
     return false;
   }
 }