Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 10917265: cc: Remove partial texture updates from scheduler. (Closed)

Created:
8 years, 3 months ago by reveman
Modified:
8 years, 3 months ago
Reviewers:
jamesr, nduca, brianderson
CC:
chromium-reviews
Visibility:
Public.

Description

cc: Remove partial texture updates from scheduler. The texture update controller now completes when all full size texture uploads are done and the texture uploader isn't busy. All partial texture updates are now done at the same time as commit. BUG=149194 TEST=cc_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157220

Patch Set 1 #

Patch Set 2 : Remove using directive and add comment about uploader being busy #

Total comments: 1

Patch Set 3 : CCTextureUpdateController API is now: Call CCTextureUpdateController::startMoreUpdates() when there… #

Patch Set 4 : upload failed. trying again.. #

Total comments: 1

Patch Set 5 : s/startMoreUpdates/performMoreUpdates/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -30 lines) Patch
M cc/CCTextureUpdateController.h View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M cc/CCTextureUpdateController.cpp View 1 2 3 4 6 chunks +47 lines, -6 lines 0 comments Download
M cc/CCTextureUpdateControllerTest.cpp View 1 2 3 4 7 chunks +16 lines, -16 lines 0 comments Download
M cc/CCThreadProxy.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/CCThreadProxy.cpp View 1 2 3 4 4 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
reveman
This is an alternative to https://chromiumcodereview.appspot.com/10918237/ (explicitly prevent drawing while performing partial updates) and is ...
8 years, 3 months ago (2012-09-14 16:35:58 UTC) #1
reveman
8 years, 3 months ago (2012-09-17 15:33:25 UTC) #2
jamesr
lgtm
8 years, 3 months ago (2012-09-17 18:05:35 UTC) #3
nduca
https://codereview.chromium.org/10917265/diff/9001/cc/CCTextureUpdateController.cpp File cc/CCTextureUpdateController.cpp (left): https://codereview.chromium.org/10917265/diff/9001/cc/CCTextureUpdateController.cpp#oldcode167 cc/CCTextureUpdateController.cpp:167: void CCTextureUpdateController::updateMoreTexturesNow() I think you could make this whole ...
8 years, 3 months ago (2012-09-17 18:26:15 UTC) #4
nduca
8 years, 3 months ago (2012-09-17 20:19:52 UTC) #5
lgtm but tweak the name

http://codereview.chromium.org/10917265/diff/6004/cc/CCTextureUpdateController.h
File cc/CCTextureUpdateController.h (right):

http://codereview.chromium.org/10917265/diff/6004/cc/CCTextureUpdateControlle...
cc/CCTextureUpdateController.h:38: void startMoreUpdates(double
monotonicTimeLimit);
processMoreUpdates/performMoreUpdates.

Powered by Google App Engine
This is Rietveld 408576698