Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(28)

Issue 10916165: Fix SafeAdd and SafeMultiply (Closed)

Created:
6 years, 5 months ago by greggman
Modified:
6 years, 5 months ago
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -31 lines) Patch
M gpu/command_buffer/common/gles2_cmd_utils.h View 1 2 3 4 4 chunks +14 lines, -13 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_unittest.cc View 1 2 3 4 2 chunks +53 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 5 chunks +12 lines, -14 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
greggman
Hey Chris, PTAL Thank you for your sample. For the GPU code I just got ...
6 years, 5 months ago (2012-09-07 01:08:34 UTC) #1
cjhopman
On 2012/09/07 01:08:34, greggman wrote: > Hey Chris, PTAL > > Thank you for your ...
6 years, 5 months ago (2012-09-07 02:05:11 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2012-09-07 08:21:15 UTC) #3
greggman
Hey Al, Can you approve this? CQ says I need another lgtm
6 years, 5 months ago (2012-09-07 09:00:28 UTC) #4
apatrick_chromium
lgtm
6 years, 5 months ago (2012-09-07 17:56:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/10916165/3007
6 years, 5 months ago (2012-09-07 18:09:29 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2012-09-07 20:54:49 UTC) #7
Change committed as 155478

Powered by Google App Engine
This is Rietveld 408576698