Improve --help and usage message for roll_deps.py

Improve --help and usage message for roll_deps.py

Also, don't use assert for user error handling plus
some other general python cleanup.

NOPRESUBMIT=true (presubmit is broken)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294950

[Sam Clegg, 2015-04-15 18:24:42]

sbc@chromium.org changed reviewers:
+ szager@google.com

[Sam Clegg, 2015-04-15 18:24:49]

sbc@chromium.org changed reviewers:
+ szager@chromium.org
- szager@google.com

[szager1, 2015-04-15 20:47:27]

lgtm, thanks for the cleanup!

[Sam Clegg, 2015-04-15 20:51:22]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2015-04-15 20:51:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1091603002/1

[commit-bot: I haz the power, 2015-04-15 20:55:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-15 20:55:22]

Presubmit check for 1091603002-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    depot_tools/roll_dep.py

tests/checkout_test.py (38.39s) failed
Cloning into '/tmp/trialxetlXZ/__main__.GitCheckout.testAll/foo'...
done.
Switched to branch 'master'
Already on 'master'
.ECloning into '/tmp/trialxetlXZ/__main__.GitCheckout.testMove/foo'...
done.
.Cloning into '/tmp/trialxetlXZ/__main__.GitCheckout.testProcess/foo'...
done.
....................
======================================================================
ERROR: testException (__main__.GitCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/checkout_test.py", line 347, in setUp
    self.enabled = self.FAKE_REPOS.set_up_git()
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 359, in set_up_git
    self.set_up()
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 211, in set_up
    self.cleanup_dirt()
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 229, in cleanup_dirt
    if not self.tear_down_git():
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 276, in tear_down_git
    wait_for_port_to_free(self.host, self.git_port)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 161, in wait_for_port_to_free
    assert False, '%d is still bound' % port
AssertionError: 20000 is still bound

----------------------------------------------------------------------
Ran 23 tests in 38.177s

FAILED (errors=1)


Presubmit checks took 216.5s to calculate.

[Sam Clegg, 2015-04-15 21:06:49]

sbc@chromium.org changed reviewers:
+ maruel@chromium.org

[Sam Clegg, 2015-04-15 21:07:06]

+maruel for OWNERS

[Sam Clegg, 2015-04-15 21:07:31]

On 2015/04/15 21:07:06, Sam Clegg wrote:
> +maruel for OWNERS

Any idea whats up the presubmit?  Looks like a flaky test.

[M-A Ruel, 2015-04-15 21:08:51]

lgtm

likely flaky test

[Sam Clegg, 2015-04-15 21:09:13]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2015-04-15 21:09:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1091603002/1

[commit-bot: I haz the power, 2015-04-15 21:13:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-15 21:13:17]

Presubmit check for 1091603002-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
tests/checkout_test.py (37.01s) failed
Cloning into '/tmp/trialf2jvxO/__main__.GitCheckout.testAll/foo'...
done.
Switched to branch 'master'
Already on 'master'
.ECloning into '/tmp/trialf2jvxO/__main__.GitCheckout.testMove/foo'...
done.
.Cloning into '/tmp/trialf2jvxO/__main__.GitCheckout.testProcess/foo'...
done.
....................
======================================================================
ERROR: testException (__main__.GitCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/checkout_test.py", line 347, in setUp
    self.enabled = self.FAKE_REPOS.set_up_git()
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 359, in set_up_git
    self.set_up()
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 211, in set_up
    self.cleanup_dirt()
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 229, in cleanup_dirt
    if not self.tear_down_git():
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 276, in tear_down_git
    wait_for_port_to_free(self.host, self.git_port)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 161, in wait_for_port_to_free
    assert False, '%d is still bound' % port
AssertionError: 20000 is still bound

----------------------------------------------------------------------
Ran 23 tests in 36.789s

FAILED (errors=1)


Presubmit checks took 221.5s to calculate.

[Sergiy Byelozyorov, 2015-04-21 12:29:25]

The CQ bit was checked by sergiyb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-21 12:29:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1091603002/1

[commit-bot: I haz the power, 2015-04-21 12:33:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-21 12:33:15]

Dry run: Presubmit check for 1091603002-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
tests/gclient_smoketest.py (52.41s) failed
Ffatal: reference is not a tree: 7ce96f4d4c98986d1d526a5e89d8ffb31f467bb2
EE..............................................
======================================================================
ERROR: testBlinkDEPSChangeUsingGit (__main__.BlinkDEPSTransitionSmokeTest)
Like testBlinkDEPSChangeUsingGclient, but move the main project using
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1630, in testBlinkDEPSChangeUsingGit
    cwd=self.checkout_path)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
484, in check_call
    check_call_out(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
478, in check_call_out
    returncode, args, kwargs.get('cwd'), out[0], out[1])
CalledProcessError: Command git checkout -q
7ce96f4d4c98986d1d526a5e89d8ffb31f467bb2 returned non-zero exit status 128 in
/tmp/trialaL9Uyc/__main__.BlinkDEPSTransitionSmokeTest.testBlinkDEPSChangeUsingGit/src

======================================================================
ERROR: testBlinkLocalBranchesArePreserved
(__main__.BlinkDEPSTransitionSmokeTest)
Checks that the state of local git branches are effectively preserved
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1656, in
testBlinkLocalBranchesArePreserved
    self.CheckStatusPreMergePoint()
  File "tests/gclient_smoketest.py", line 1558, in CheckStatusPreMergePoint
    self.blink), self.blink_git_url)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/scm.py", line
121, in Capture
    cwd=cwd, stderr=subprocess2.PIPE, env=env, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
515, in check_output
    return check_call_out(args, stdout=PIPE, **kwargs)[0]
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
475, in check_call_out
    out, returncode = communicate(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
449, in communicate
    proc = Popen(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
253, in __init__
    % (str(e), kwargs.get('cwd'), args[0]))
OSError: Execution failed with error: [Errno 2] No such file or directory:
'/tmp/trialaL9Uyc/__main__.BlinkDEPSTransitionSmokeTest.testBlinkLocalBranchesArePreserved/src/third_party/WebKit'.
Check that
/tmp/trialaL9Uyc/__main__.BlinkDEPSTransitionSmokeTest.testBlinkLocalBranchesArePreserved/src/third_party/WebKit
or git exist and have execution permission.

======================================================================
FAIL: testBlinkDEPSChangeUsingGclient (__main__.BlinkDEPSTransitionSmokeTest)
Checks that {src,blink} repos are consistent when syncing going back and
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1601, in
testBlinkDEPSChangeUsingGclient
    self.assertEqual(res[2], 0, 'DEPS change sync failed.')
AssertionError: DEPS change sync failed.

----------------------------------------------------------------------
Ran 49 tests in 52.230s

FAILED (failures=1, errors=2)


Presubmit checks took 213.7s to calculate.

[Sergiy Byelozyorov, 2015-04-21 14:06:36]

The CQ bit was checked by sergiyb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-21 14:06:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1091603002/1

[commit-bot: I haz the power, 2015-04-21 14:10:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-21 14:10:18]

Dry run: Presubmit check for 1091603002-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
tests/gclient_smoketest.py (63.80s) failed
Ffatal: reference is not a tree: 366d2e36ec8c87944d0488926bbffba45b2c80fa
EE..............................................
======================================================================
ERROR: testBlinkDEPSChangeUsingGit (__main__.BlinkDEPSTransitionSmokeTest)
Like testBlinkDEPSChangeUsingGclient, but move the main project using
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1630, in testBlinkDEPSChangeUsingGit
    cwd=self.checkout_path)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
484, in check_call
    check_call_out(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
478, in check_call_out
    returncode, args, kwargs.get('cwd'), out[0], out[1])
CalledProcessError: Command git checkout -q
366d2e36ec8c87944d0488926bbffba45b2c80fa returned non-zero exit status 128 in
/tmp/trialpycQAl/__main__.BlinkDEPSTransitionSmokeTest.testBlinkDEPSChangeUsingGit/src

======================================================================
ERROR: testBlinkLocalBranchesArePreserved
(__main__.BlinkDEPSTransitionSmokeTest)
Checks that the state of local git branches are effectively preserved
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1656, in
testBlinkLocalBranchesArePreserved
    self.CheckStatusPreMergePoint()
  File "tests/gclient_smoketest.py", line 1558, in CheckStatusPreMergePoint
    self.blink), self.blink_git_url)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/scm.py", line
121, in Capture
    cwd=cwd, stderr=subprocess2.PIPE, env=env, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
515, in check_output
    return check_call_out(args, stdout=PIPE, **kwargs)[0]
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
475, in check_call_out
    out, returncode = communicate(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
449, in communicate
    proc = Popen(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
253, in __init__
    % (str(e), kwargs.get('cwd'), args[0]))
OSError: Execution failed with error: [Errno 2] No such file or directory:
'/tmp/trialpycQAl/__main__.BlinkDEPSTransitionSmokeTest.testBlinkLocalBranchesArePreserved/src/third_party/WebKit'.
Check that
/tmp/trialpycQAl/__main__.BlinkDEPSTransitionSmokeTest.testBlinkLocalBranchesArePreserved/src/third_party/WebKit
or git exist and have execution permission.

======================================================================
FAIL: testBlinkDEPSChangeUsingGclient (__main__.BlinkDEPSTransitionSmokeTest)
Checks that {src,blink} repos are consistent when syncing going back and
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1601, in
testBlinkDEPSChangeUsingGclient
    self.assertEqual(res[2], 0, 'DEPS change sync failed.')
AssertionError: DEPS change sync failed.

----------------------------------------------------------------------
Ran 49 tests in 63.601s

FAILED (failures=1, errors=2)


Presubmit checks took 198.4s to calculate.

[Sergiy Byelozyorov, 2015-04-21 14:37:18]

The CQ bit was checked by sergiyb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-21 14:39:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1091603002/1

[commit-bot: I haz the power, 2015-04-21 14:42:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-21 14:42:37]

Dry run: This issue passed the CQ dry run.

[Sam Clegg, 2015-04-22 18:58:24]

The CQ bit was checked by sbc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-22 18:58:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1091603002/1

[commit-bot: I haz the power, 2015-04-22 19:02:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-22 19:02:13]

Dry run: Presubmit check for 1091603002-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
tests/gclient_smoketest.py (53.77s) failed
Ffatal: reference is not a tree: fbaefff5337d5e89437a2f28aa4e0ab070ee7bc5
EE..............................................
======================================================================
ERROR: testBlinkDEPSChangeUsingGit (__main__.BlinkDEPSTransitionSmokeTest)
Like testBlinkDEPSChangeUsingGclient, but move the main project using
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1630, in testBlinkDEPSChangeUsingGit
    cwd=self.checkout_path)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
484, in check_call
    check_call_out(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
478, in check_call_out
    returncode, args, kwargs.get('cwd'), out[0], out[1])
CalledProcessError: Command git checkout -q
fbaefff5337d5e89437a2f28aa4e0ab070ee7bc5 returned non-zero exit status 128 in
/tmp/trialc3I53t/__main__.BlinkDEPSTransitionSmokeTest.testBlinkDEPSChangeUsingGit/src

======================================================================
ERROR: testBlinkLocalBranchesArePreserved
(__main__.BlinkDEPSTransitionSmokeTest)
Checks that the state of local git branches are effectively preserved
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1656, in
testBlinkLocalBranchesArePreserved
    self.CheckStatusPreMergePoint()
  File "tests/gclient_smoketest.py", line 1558, in CheckStatusPreMergePoint
    self.blink), self.blink_git_url)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/scm.py", line
121, in Capture
    cwd=cwd, stderr=subprocess2.PIPE, env=env, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
515, in check_output
    return check_call_out(args, stdout=PIPE, **kwargs)[0]
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
475, in check_call_out
    out, returncode = communicate(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
449, in communicate
    proc = Popen(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
253, in __init__
    % (str(e), kwargs.get('cwd'), args[0]))
OSError: Execution failed with error: [Errno 2] No such file or directory:
'/tmp/trialc3I53t/__main__.BlinkDEPSTransitionSmokeTest.testBlinkLocalBranchesArePreserved/src/third_party/WebKit'.
Check that
/tmp/trialc3I53t/__main__.BlinkDEPSTransitionSmokeTest.testBlinkLocalBranchesArePreserved/src/third_party/WebKit
or git exist and have execution permission.

======================================================================
FAIL: testBlinkDEPSChangeUsingGclient (__main__.BlinkDEPSTransitionSmokeTest)
Checks that {src,blink} repos are consistent when syncing going back and
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1601, in
testBlinkDEPSChangeUsingGclient
    self.assertEqual(res[2], 0, 'DEPS change sync failed.')
AssertionError: DEPS change sync failed.

----------------------------------------------------------------------
Ran 49 tests in 53.616s

FAILED (failures=1, errors=2)


Presubmit checks took 208.6s to calculate.

[Sam Clegg, 2015-04-22 19:04:57]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2015-04-22 19:05:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1091603002/1

[commit-bot: I haz the power, 2015-04-22 19:08:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-22 19:08:52]

Presubmit check for 1091603002-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
tests/gclient_smoketest.py (52.26s) failed
Ffatal: reference is not a tree: 6cb10b18c8daff8e3ad8b6bff8ec04d59d78fcf3
EE..............................................
======================================================================
ERROR: testBlinkDEPSChangeUsingGit (__main__.BlinkDEPSTransitionSmokeTest)
Like testBlinkDEPSChangeUsingGclient, but move the main project using
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1630, in testBlinkDEPSChangeUsingGit
    cwd=self.checkout_path)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
484, in check_call
    check_call_out(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
478, in check_call_out
    returncode, args, kwargs.get('cwd'), out[0], out[1])
CalledProcessError: Command git checkout -q
6cb10b18c8daff8e3ad8b6bff8ec04d59d78fcf3 returned non-zero exit status 128 in
/tmp/trialWDt0oX/__main__.BlinkDEPSTransitionSmokeTest.testBlinkDEPSChangeUsingGit/src

======================================================================
ERROR: testBlinkLocalBranchesArePreserved
(__main__.BlinkDEPSTransitionSmokeTest)
Checks that the state of local git branches are effectively preserved
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1656, in
testBlinkLocalBranchesArePreserved
    self.CheckStatusPreMergePoint()
  File "tests/gclient_smoketest.py", line 1558, in CheckStatusPreMergePoint
    self.blink), self.blink_git_url)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/scm.py", line
121, in Capture
    cwd=cwd, stderr=subprocess2.PIPE, env=env, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
515, in check_output
    return check_call_out(args, stdout=PIPE, **kwargs)[0]
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
475, in check_call_out
    out, returncode = communicate(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
449, in communicate
    proc = Popen(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
253, in __init__
    % (str(e), kwargs.get('cwd'), args[0]))
OSError: Execution failed with error: [Errno 2] No such file or directory:
'/tmp/trialWDt0oX/__main__.BlinkDEPSTransitionSmokeTest.testBlinkLocalBranchesArePreserved/src/third_party/WebKit'.
Check that
/tmp/trialWDt0oX/__main__.BlinkDEPSTransitionSmokeTest.testBlinkLocalBranchesArePreserved/src/third_party/WebKit
or git exist and have execution permission.

======================================================================
FAIL: testBlinkDEPSChangeUsingGclient (__main__.BlinkDEPSTransitionSmokeTest)
Checks that {src,blink} repos are consistent when syncing going back and
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1601, in
testBlinkDEPSChangeUsingGclient
    self.assertEqual(res[2], 0, 'DEPS change sync failed.')
AssertionError: DEPS change sync failed.

----------------------------------------------------------------------
Ran 49 tests in 52.053s

FAILED (failures=1, errors=2)


Presubmit checks took 208.5s to calculate.

[Sam Clegg, 2015-04-22 19:14:05]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2015-04-22 19:14:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1091603002/1

[commit-bot: I haz the power, 2015-04-22 19:22:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-22 19:22:03]

Presubmit check for 1091603002-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
push-basic.sh failed
Command
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/push-basic.sh
returned non-zero exit status 1 in
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests
Setting up test upstream git repo...
Setting up test git repo...
TESTING: git-cl upload wants a server
TESTING: git-cl status has no issue
TESTING: upload succeeds (needs a server running on localhost)
TESTING: git-cl status now knows the issue
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--    
0
100    77    0     0  100    77      0   1452 --:--:-- --:--:-- --:--:--  1480
TESTING: Base URL contains branch name
TESTING: git-cl land ok

Please go to
https://www.google.com/accounts/DisplayUnlockCaptcha
and verify you are a human.  Then try again.
If you are using a Google Apps account the URL is:
https://www.google.com/a/yourdomain.com/UnlockCaptcha


Please go to
https://www.google.com/accounts/DisplayUnlockCaptcha
and verify you are a human.  Then try again.
If you are using a Google Apps account the URL is:
https://www.google.com/a/yourdomain.com/UnlockCaptcha


Please go to
https://www.google.com/accounts/DisplayUnlockCaptcha
and verify you are a human.  Then try again.
If you are using a Google Apps account the URL is:
https://www.google.com/a/yourdomain.com/UnlockCaptcha

Access to http://localhost:10000 is denied (server returned HTTP 403).
Using 50% similarity for rename/copy detection. Override with --similarity.
Loaded authentication cookies from /home/chrome-bot/.codereview_upload_cookies
Running presubmit commit checks ...

Presubmit checks passed.
Description:
foo-quux

Review URL: http://localhost:10000/5629499534213120
Closing issue (you may be prompted for your codereview password)...
Saving authentication cookies to /home/chrome-bot/.codereview_upload_cookies
FAILURE: git-cl land ok


Presubmit checks took 208.1s to calculate.

[Sam Clegg, 2015-04-22 19:29:11]

On 2015/04/22 19:22:03, I haz the power (commit-bot) wrote:
> Presubmit check for 1091603002-1 failed and returned exit status 1.
> 
> Running presubmit commit checks ...
> Checking out rietveld...
> Running save-description-on-failure.sh
> Running push-basic.sh
> Running upstream.sh
> Running submit-from-new-dir.sh
> Running abandon.sh
> Running submodule-merge-test.sh
> Running upload-local-tracking-branch.sh
> Running hooks.sh
> Running post-dcommit-hook-test.sh
> Running upload-stale.sh
> Running patch.sh
> Running basic.sh
> 
> ** Presubmit ERRORS **
> push-basic.sh failed
> Command
> /b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/push-basic.sh
> returned non-zero exit status 1 in
> /b/infra_internal/commit_queue/workdir/tools/depot_tools/tests
> Setting up test upstream git repo...
> Setting up test git repo...
> TESTING: git-cl upload wants a server
> TESTING: git-cl status has no issue
> TESTING: upload succeeds (needs a server running on localhost)
> TESTING: git-cl status now knows the issue
>   % Total    % Received % Xferd  Average Speed   Time    Time     Time 
Current
>                                  Dload  Upload   Total   Spent    Left  Speed
> 
>   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--    
> 0
> 100    77    0     0  100    77      0   1452 --:--:-- --:--:-- --:--:--  1480
> TESTING: Base URL contains branch name
> TESTING: git-cl land ok
> 
> Please go to
> https://www.google.com/accounts/DisplayUnlockCaptcha
> and verify you are a human.  Then try again.
> If you are using a Google Apps account the URL is:
> https://www.google.com/a/yourdomain.com/UnlockCaptcha
> 
> 
> Please go to
> https://www.google.com/accounts/DisplayUnlockCaptcha
> and verify you are a human.  Then try again.
> If you are using a Google Apps account the URL is:
> https://www.google.com/a/yourdomain.com/UnlockCaptcha
> 
> 
> Please go to
> https://www.google.com/accounts/DisplayUnlockCaptcha
> and verify you are a human.  Then try again.
> If you are using a Google Apps account the URL is:
> https://www.google.com/a/yourdomain.com/UnlockCaptcha
> 
> Access to http://localhost:10000 is denied (server returned HTTP 403).
> Using 50% similarity for rename/copy detection. Override with --similarity.
> Loaded authentication cookies from /home/chrome-bot/.codereview_upload_cookies
> Running presubmit commit checks ...
> 
> Presubmit checks passed.
> Description:
> foo-quux
> 
> Review URL: http://localhost:10000/5629499534213120
> Closing issue (you may be prompted for your codereview password)...
> Saving authentication cookies to /home/chrome-bot/.codereview_upload_cookies
> FAILURE: git-cl land ok
> 
> 
> Presubmit checks took 208.1s to calculate.

Any idea whats up with this now?

[M-A Ruel, 2015-04-22 19:39:04]

Sorry for the annoyance, it looks related to new OAuth2 support Vadim
worked on. Vadim, can you confirm/deny?

M-A

2015-04-22 12:29 GMT-07:00 <sbc@chromium.org>:

> On 2015/04/22 19:22:03, I haz the power (commit-bot) wrote:
>
>> Presubmit check for 1091603002-1 failed and returned exit status 1.
>>
>
>  Running presubmit commit checks ...
>> Checking out rietveld...
>> Running save-description-on-failure.sh
>> Running push-basic.sh
>> Running upstream.sh
>> Running submit-from-new-dir.sh
>> Running abandon.sh
>> Running submodule-merge-test.sh
>> Running upload-local-tracking-branch.sh
>> Running hooks.sh
>> Running post-dcommit-hook-test.sh
>> Running upload-stale.sh
>> Running patch.sh
>> Running basic.sh
>>
>
>  ** Presubmit ERRORS **
>> push-basic.sh failed
>> Command
>>
>> /b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/push-basic.sh
>> returned non-zero exit status 1 in
>> /b/infra_internal/commit_queue/workdir/tools/depot_tools/tests
>> Setting up test upstream git repo...
>> Setting up test git repo...
>> TESTING: git-cl upload wants a server
>> TESTING: git-cl status has no issue
>> TESTING: upload succeeds (needs a server running on localhost)
>> TESTING: git-cl status now knows the issue
>>    % Total    % Received % Xferd  Average Speed   Time    Time     Time
>>
> Current
>
>>                                   Dload  Upload   Total   Spent    Left
>> Speed
>>
>
>     0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--
>> 0
>> 100    77    0     0  100    77      0   1452 --:--:-- --:--:-- --:--:--
>> 1480
>> TESTING: Base URL contains branch name
>> TESTING: git-cl land ok
>>
>
>  Please go to
>> https://www.google.com/accounts/DisplayUnlockCaptcha
>> and verify you are a human.  Then try again.
>> If you are using a Google Apps account the URL is:
>> https://www.google.com/a/yourdomain.com/UnlockCaptcha
>>
>
>
>  Please go to
>> https://www.google.com/accounts/DisplayUnlockCaptcha
>> and verify you are a human.  Then try again.
>> If you are using a Google Apps account the URL is:
>> https://www.google.com/a/yourdomain.com/UnlockCaptcha
>>
>
>
>  Please go to
>> https://www.google.com/accounts/DisplayUnlockCaptcha
>> and verify you are a human.  Then try again.
>> If you are using a Google Apps account the URL is:
>> https://www.google.com/a/yourdomain.com/UnlockCaptcha
>>
>
>  Access to http://localhost:10000 is denied (server returned HTTP 403).
>> Using 50% similarity for rename/copy detection. Override with
>> --similarity.
>> Loaded authentication cookies from
>> /home/chrome-bot/.codereview_upload_cookies
>> Running presubmit commit checks ...
>>
>
>  Presubmit checks passed.
>> Description:
>> foo-quux
>>
>
>  Review URL: http://localhost:10000/5629499534213120
>> Closing issue (you may be prompted for your codereview password)...
>> Saving authentication cookies to
>> /home/chrome-bot/.codereview_upload_cookies
>> FAILURE: git-cl land ok
>>
>
>
>  Presubmit checks took 208.1s to calculate.
>>
>
> Any idea whats up with this now?
>
> https://codereview.chromium.org/1091603002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Vadim Sh., 2015-04-22 19:48:00]

On 2015/04/22 19:39:04, M-A Ruel wrote:
> Sorry for the annoyance, it looks related to new OAuth2 support Vadim
> worked on. Vadim, can you confirm/deny?
> 
> M-A
> 
> 2015-04-22 12:29 GMT-07:00 <mailto:sbc@chromium.org>:
> 
> > On 2015/04/22 19:22:03, I haz the power (commit-bot) wrote:
> >
> >> Presubmit check for 1091603002-1 failed and returned exit status 1.
> >>
> >
> >  Running presubmit commit checks ...
> >> Checking out rietveld...
> >> Running save-description-on-failure.sh
> >> Running push-basic.sh
> >> Running upstream.sh
> >> Running submit-from-new-dir.sh
> >> Running abandon.sh
> >> Running submodule-merge-test.sh
> >> Running upload-local-tracking-branch.sh
> >> Running hooks.sh
> >> Running post-dcommit-hook-test.sh
> >> Running upload-stale.sh
> >> Running patch.sh
> >> Running basic.sh
> >>
> >
> >  ** Presubmit ERRORS **
> >> push-basic.sh failed
> >> Command
> >>
> >>
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/push-basic.sh
> >> returned non-zero exit status 1 in
> >> /b/infra_internal/commit_queue/workdir/tools/depot_tools/tests
> >> Setting up test upstream git repo...
> >> Setting up test git repo...
> >> TESTING: git-cl upload wants a server
> >> TESTING: git-cl status has no issue
> >> TESTING: upload succeeds (needs a server running on localhost)
> >> TESTING: git-cl status now knows the issue
> >>    % Total    % Received % Xferd  Average Speed   Time    Time     Time
> >>
> > Current
> >
> >>                                   Dload  Upload   Total   Spent    Left
> >> Speed
> >>
> >
> >     0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--
> >> 0
> >> 100    77    0     0  100    77      0   1452 --:--:-- --:--:-- --:--:--
> >> 1480
> >> TESTING: Base URL contains branch name
> >> TESTING: git-cl land ok
> >>
> >
> >  Please go to
> >> https://www.google.com/accounts/DisplayUnlockCaptcha
> >> and verify you are a human.  Then try again.
> >> If you are using a Google Apps account the URL is:
> >> https://www.google.com/a/yourdomain.com/UnlockCaptcha
> >>
> >
> >
> >  Please go to
> >> https://www.google.com/accounts/DisplayUnlockCaptcha
> >> and verify you are a human.  Then try again.
> >> If you are using a Google Apps account the URL is:
> >> https://www.google.com/a/yourdomain.com/UnlockCaptcha
> >>
> >
> >
> >  Please go to
> >> https://www.google.com/accounts/DisplayUnlockCaptcha
> >> and verify you are a human.  Then try again.
> >> If you are using a Google Apps account the URL is:
> >> https://www.google.com/a/yourdomain.com/UnlockCaptcha
> >>
> >
> >  Access to http://localhost:10000 is denied (server returned HTTP 403).
> >> Using 50% similarity for rename/copy detection. Override with
> >> --similarity.
> >> Loaded authentication cookies from
> >> /home/chrome-bot/.codereview_upload_cookies
> >> Running presubmit commit checks ...
> >>
> >
> >  Presubmit checks passed.
> >> Description:
> >> foo-quux
> >>
> >
> >  Review URL: http://localhost:10000/5629499534213120
> >> Closing issue (you may be prompted for your codereview password)...
> >> Saving authentication cookies to
> >> /home/chrome-bot/.codereview_upload_cookies
> >> FAILURE: git-cl land ok
> >>
> >
> >
> >  Presubmit checks took 208.1s to calculate.
> >>
> >
> > Any idea whats up with this now?
> >
> > https://codereview.chromium.org/1091603002/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

It is a flake. Happened here https://codereview.chromium.org/1095033002 too, and
went away on a retry.

I don't think it's related to my change since tests are not used OAuth2 stuff
(line "Saving authentication cookies to ..." is an evidence). I don't know where
captcha prompt is coming from... I suspect the test is hitting real ClientLogin
endpoint and occasionally it complains with captcha requests (probable when
request rate from commit-bot@chromium.org is too high).

[Vadim Sh., 2015-04-22 20:02:01]

Eh, since I've spent some time investigating this flake already I'll try to fix
it. Meanwhile NOPRESUBMIT=true is probably fine.

[Sam Clegg, 2015-04-22 20:13:26]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2015-04-22 20:13:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1091603002/1

[commit-bot: I haz the power, 2015-04-22 20:21:37]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294950