Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1095033002: Enable OAuth2 by default. (Closed)

Created:
5 years, 8 months ago by Vadim Sh.
Modified:
5 years, 8 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
tools
Visibility:
Public.

Description

Enable OAuth2 by default. ClientLogin will be supposedly turned off on Apr 20. R=maruel@chromium.org BUG=356813 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294899

Patch Set 1 #

Patch Set 2 : fix smoke tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -39 lines) Patch
M .gitignore View 1 chunk +0 lines, -4 lines 0 comments Download
M auth.py View 2 chunks +1 line, -9 lines 0 comments Download
M tests/abandon.sh View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/basic.sh View 1 3 chunks +3 lines, -3 lines 0 comments Download
M tests/git_cl_test.py View 2 chunks +1 line, -2 lines 0 comments Download
M tests/owners.sh View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/patch.sh View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/post-dcommit-hook-test.sh View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/push-basic.sh View 1 3 chunks +3 lines, -3 lines 0 comments Download
M tests/push-from-logs.sh View 1 3 chunks +4 lines, -4 lines 0 comments Download
M tests/rename.sh View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/save-description-on-failure.sh View 1 1 chunk +2 lines, -1 line 0 comments Download
M tests/submit-from-new-dir.sh View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/submodule-merge-test.sh View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/upload-local-tracking-branch.sh View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/upload-stale.sh View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
Vadim Sh.
5 years, 8 months ago (2015-04-19 19:19:18 UTC) #1
M-A Ruel
lgtm
5 years, 8 months ago (2015-04-19 19:27:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095033002/1
5 years, 8 months ago (2015-04-20 16:16:03 UTC) #4
commit-bot: I haz the power
Presubmit check for 1095033002-1 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 8 months ago (2015-04-20 16:19:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095033002/20001
5 years, 8 months ago (2015-04-20 16:35:48 UTC) #9
commit-bot: I haz the power
Presubmit check for 1095033002-20001 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 8 months ago (2015-04-20 16:38:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095033002/20001
5 years, 8 months ago (2015-04-20 16:59:48 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-20 17:03:15 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294899

Powered by Google App Engine
This is Rietveld 408576698