Issue 10915318: Revert 157168 - Add guards to metric values; erase bad events/metrics from db

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10915318: Revert 157168 - Add guards to metric values; erase bad events/metrics from db (Closed)

Created:
8 years, 3 months ago by Devlin

Modified:
8 years, 3 months ago

Reviewers:
Devlin

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 157168 - Add guards to metric values; erase bad events/metrics from db Improves the database by not inserting blatantly erroneous data, and by deleting any events or metrics which cannot be properly retrieved from the database. Also make DB take a metric for AddMetric() - this makes it so that we have a more accurate timestamp since we record the time before the thread-jumping. BUG=130212 Review URL: https://chromiumcodereview.appspot.com/10907121 TBR=rdevlin.cronin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157182

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+106 lines, -396 lines)			Patch
M	chrome/browser/performance_monitor/constants.h	View	2 chunks	+0 lines, -17 lines	0 comments	Download
M	chrome/browser/performance_monitor/constants.cc	View	2 chunks	+2 lines, -14 lines	0 comments	Download
M	chrome/browser/performance_monitor/database.h	View	3 chunks	+7 lines, -5 lines	0 comments	Download
M	chrome/browser/performance_monitor/database.cc	View	9 chunks	+22 lines, -65 lines	0 comments	Download
M	chrome/browser/performance_monitor/database_unittest.cc	View	10 chunks	+22 lines, -144 lines	0 comments	Download
M	chrome/browser/performance_monitor/metric.h	View	1 chunk	+2 lines, -17 lines	0 comments	Download
MM	chrome/browser/performance_monitor/metric.cc	View	2 chunks	+4 lines, -75 lines	0 comments	Download
M	chrome/browser/performance_monitor/performance_monitor.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/performance_monitor/performance_monitor.cc	View	5 chunks	+12 lines, -19 lines	0 comments	Download
M	chrome/browser/performance_monitor/startup_timer.cc	View	3 chunks	+8 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/webui/performance_monitor/performance_monitor_ui_constants.cc	View	1 chunk	+13 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/performance_monitor/performance_monitor_ui_util.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/performance_monitor/performance_monitor_ui_util.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/performance_monitor/performance_monitor_ui_util_unittest.cc	View	4 chunks	+10 lines, -21 lines	0 comments	Download
M	chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages