Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2611)

Unified Diff: chrome/browser/performance_monitor/startup_timer.cc

Issue 10915318: Revert 157168 - Add guards to metric values; erase bad events/metrics from db (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/performance_monitor/startup_timer.cc
===================================================================
--- chrome/browser/performance_monitor/startup_timer.cc (revision 157181)
+++ chrome/browser/performance_monitor/startup_timer.cc (working copy)
@@ -21,8 +21,9 @@
namespace {
// Needed because Database::AddMetric is overloaded, so base::Bind doesn't work.
void AddMetricToDatabaseOnBackgroundThread(Database* database,
- Metric metric) {
- database->AddMetric(metric);
+ MetricType metric,
+ std::string value) {
+ database->AddMetric(metric, value);
}
} // namespace
@@ -113,11 +114,9 @@
base::Bind(
&AddMetricToDatabaseOnBackgroundThread,
base::Unretained(PerformanceMonitor::GetInstance()->database()),
- Metric(startup_type_ == STARTUP_NORMAL ? METRIC_STARTUP_TIME
- : METRIC_TEST_STARTUP_TIME,
- base::Time::Now(),
- static_cast<double>(
- elapsed_startup_time_.ToInternalValue()))));
+ startup_type_ == STARTUP_NORMAL ? METRIC_STARTUP_TIME
+ : METRIC_TEST_STARTUP_TIME,
+ base::Int64ToString(elapsed_startup_time_.ToInternalValue())));
}
void StartupTimer::InsertElapsedSessionRestoreTime() {
@@ -130,9 +129,8 @@
base::Bind(
&AddMetricToDatabaseOnBackgroundThread,
base::Unretained(PerformanceMonitor::GetInstance()->database()),
- Metric(METRIC_SESSION_RESTORE_TIME,
- base::Time::Now(),
- static_cast<double>(iter->ToInternalValue()))));
+ METRIC_SESSION_RESTORE_TIME,
+ base::Int64ToString(iter->ToInternalValue())));
}
}

Powered by Google App Engine
This is Rietveld 408576698