Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Unified Diff: pkg/args/lib/args.dart

Issue 10914320: change addOption callback argument from bool to Dynamic (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/args/lib/args.dart
diff --git a/pkg/args/lib/args.dart b/pkg/args/lib/args.dart
index b49bc1a3dace91a51a128c0bbccec251fc0d963f..b923606eca3a0270eaab16f3e7c86eca787c4003 100644
--- a/pkg/args/lib/args.dart
+++ b/pkg/args/lib/args.dart
@@ -239,14 +239,14 @@ class ArgParser {
*/
void addOption(String name, [String abbr, String help, List<String> allowed,
Map<String, String> allowedHelp, String defaultsTo,
- void callback(bool value), bool allowMultiple = false]) {
+ void callback(Dynamic value), bool allowMultiple = false]) {
Bob Nystrom 2012/09/18 00:43:25 I don't know if the style guide mentions this (it
butlermatt 2012/09/18 13:13:50 Done.
_addOption(name, abbr, help, allowed, allowedHelp, defaultsTo,
callback, isFlag: false, allowMultiple: allowMultiple);
}
void _addOption(String name, String abbr, String help, List<String> allowed,
Map<String, String> allowedHelp, defaultsTo,
- void callback(bool value), [bool isFlag, bool negatable = false,
+ void callback(Dynamic value), [bool isFlag, bool negatable = false,
Bob Nystrom 2012/09/18 00:43:25 And here.
butlermatt 2012/09/18 13:13:50 Done.
bool allowMultiple = false]) {
// Make sure the name isn't in use.
if (_options.containsKey(name)) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698