change addOption callback argument from bool to Dynamic

change addOption callback argument from bool to Dynamic


BUG=http://dartbug.com/5199

[butlermatt, 2012-09-17 17:15:25]

Used Dynamic instead of string as mentioned in bug report to better support
allowMultiple flag, which causes a list to be passed.

[Bob Nystrom, 2012-09-18 00:43:25]

Now that you mention this, there don't appear to be tests for what gets passed
to the callback in the allowMultiple case. Care to write a couple of tests too?
:)

https://codereview.chromium.org/10914320/diff/1/pkg/args/lib/args.dart
File pkg/args/lib/args.dart (right):

https://codereview.chromium.org/10914320/diff/1/pkg/args/lib/args.dart#newcod...
pkg/args/lib/args.dart:242: void callback(Dynamic value), bool allowMultiple =
false]) {
I don't know if the style guide mentions this (it should), but if a parameter's
type is Dynamic, we just don't annotate it at all. So you can just remove the
type annotation here.

https://codereview.chromium.org/10914320/diff/1/pkg/args/lib/args.dart#newcod...
pkg/args/lib/args.dart:249: void callback(Dynamic value), [bool isFlag, bool
negatable = false,
And here.

[butlermatt, 2012-09-18 13:13:50]

Fixed my annotations and added 4 tests for allowMultiple.

https://codereview.chromium.org/10914320/diff/1/pkg/args/lib/args.dart
File pkg/args/lib/args.dart (right):

https://codereview.chromium.org/10914320/diff/1/pkg/args/lib/args.dart#newcod...
pkg/args/lib/args.dart:242: void callback(Dynamic value), bool allowMultiple =
false]) {
On 2012/09/18 00:43:25, Bob Nystrom wrote:
> I don't know if the style guide mentions this (it should), but if a
parameter's
> type is Dynamic, we just don't annotate it at all. So you can just remove the
> type annotation here.

Done.

https://codereview.chromium.org/10914320/diff/1/pkg/args/lib/args.dart#newcod...
pkg/args/lib/args.dart:249: void callback(Dynamic value), [bool isFlag, bool
negatable = false,
On 2012/09/18 00:43:25, Bob Nystrom wrote:
> And here.

Done.

[Bob Nystrom, 2012-09-19 21:14:08]

LGTM, nicely done! I'll take this patch and submit it for you.

[Bob Nystrom, 2012-09-19 21:21:17]

On 2012/09/19 21:14:08, Bob Nystrom wrote:
> LGTM, nicely done! I'll take this patch and submit it for you.

Committed: https://codereview.chromium.org/10947044/