Add average commit time to perf tests.

Add average commit time to texture upload scrolling tests

BUG=151456
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158950

[nduca, 2012-09-15 00:36:09]

LGTMish

https://codereview.chromium.org/10914304/diff/1/cc/CCSingleThreadProxy.cpp
File cc/CCSingleThreadProxy.cpp (right):

https://codereview.chromium.org/10914304/diff/1/cc/CCSingleThreadProxy.cpp#ne...
cc/CCSingleThreadProxy.cpp:31: , m_totalCommitTime(0)
here and elsewhere, add unit. m_totalCommitTimeInSeconds

https://codereview.chromium.org/10914304/diff/1/cc/CCSingleThreadProxy.h
File cc/CCSingleThreadProxy.h (right):

https://codereview.chromium.org/10914304/diff/1/cc/CCSingleThreadProxy.h#newc...
cc/CCSingleThreadProxy.h:82: // Statistics
not sure we need the comment.

https://codereview.chromium.org/10914304/diff/1/cc/CCThreadProxy.h
File cc/CCThreadProxy.h (right):

https://codereview.chromium.org/10914304/diff/1/cc/CCThreadProxy.h#newcode177
cc/CCThreadProxy.h:177: // Statistics
meh on comment

https://codereview.chromium.org/10914304/diff/1/content/renderer/gpu/gpu_benc...
File content/renderer/gpu/gpu_benchmarking_extension.cc (right):

https://codereview.chromium.org/10914304/diff/1/content/renderer/gpu/gpu_benc...
content/renderer/gpu/gpu_benchmarking_extension.cc:170:
stats_object->Set(v8::String::New("totalCommitTimeInSeconds"),
I dont think you can do this in the same patch. stats here is a
WebRenderingStats. Leave this file alone until you've landed the
webrenderingstats change.

[nduca, 2012-09-15 00:49:35]

Or maybe you can do this in on echange once you land the webkit change first? I
just dont know how that all works yet. Just be careful :)

[reveman, 2012-09-15 01:49:05]

lgtm

https://codereview.chromium.org/10914304/diff/1/cc/CCProxy.h
File cc/CCProxy.h (right):

https://codereview.chromium.org/10914304/diff/1/cc/CCProxy.h#newcode61
cc/CCProxy.h:61: virtual void renderingStats(CCRenderingStats&) = 0;
while updating this function prototype maybe we should switch to chromium style
and not use references but pointers for return values?

https://codereview.chromium.org/10914304/diff/1/content/renderer/gpu/gpu_benc...
File content/renderer/gpu/gpu_benchmarking_extension.cc (right):

https://codereview.chromium.org/10914304/diff/1/content/renderer/gpu/gpu_benc...
content/renderer/gpu/gpu_benchmarking_extension.cc:140: 
maybe remove this newline before landing unless you added it purposely?

[brianderson, 2012-09-18 01:16:43]

https://codereview.chromium.org/10914304/diff/1/cc/CCProxy.h
File cc/CCProxy.h (right):

https://codereview.chromium.org/10914304/diff/1/cc/CCProxy.h#newcode61
cc/CCProxy.h:61: virtual void renderingStats(CCRenderingStats&) = 0;
On 2012/09/15 01:49:05, David Reveman wrote:
> while updating this function prototype maybe we should switch to chromium
style
> and not use references but pointers for return values?

Don't have time right now.

https://codereview.chromium.org/10914304/diff/1/cc/CCSingleThreadProxy.cpp
File cc/CCSingleThreadProxy.cpp (right):

https://codereview.chromium.org/10914304/diff/1/cc/CCSingleThreadProxy.cpp#ne...
cc/CCSingleThreadProxy.cpp:31: , m_totalCommitTime(0)
On 2012/09/15 00:36:09, nduca wrote:
> here and elsewhere, add unit. m_totalCommitTimeInSeconds

Done.

https://codereview.chromium.org/10914304/diff/1/cc/CCSingleThreadProxy.h
File cc/CCSingleThreadProxy.h (right):

https://codereview.chromium.org/10914304/diff/1/cc/CCSingleThreadProxy.h#newc...
cc/CCSingleThreadProxy.h:82: // Statistics
On 2012/09/15 00:36:09, nduca wrote:
> not sure we need the comment.

Done.

https://codereview.chromium.org/10914304/diff/1/cc/CCThreadProxy.h
File cc/CCThreadProxy.h (right):

https://codereview.chromium.org/10914304/diff/1/cc/CCThreadProxy.h#newcode177
cc/CCThreadProxy.h:177: // Statistics
On 2012/09/15 00:36:09, nduca wrote:
> meh on comment

Done.

https://codereview.chromium.org/10914304/diff/1/content/renderer/gpu/gpu_benc...
File content/renderer/gpu/gpu_benchmarking_extension.cc (right):

https://codereview.chromium.org/10914304/diff/1/content/renderer/gpu/gpu_benc...
content/renderer/gpu/gpu_benchmarking_extension.cc:140: 
On 2012/09/15 01:49:05, David Reveman wrote:
> maybe remove this newline before landing unless you added it purposely?

Done.

https://codereview.chromium.org/10914304/diff/1/content/renderer/gpu/gpu_benc...
content/renderer/gpu/gpu_benchmarking_extension.cc:170:
stats_object->Set(v8::String::New("totalCommitTimeInSeconds"),
On 2012/09/15 00:36:09, nduca wrote:
> I dont think you can do this in the same patch. stats here is a
> WebRenderingStats. Leave this file alone until you've landed the
> webrenderingstats change.

Will wait for the webkit side to land before committing this patch.

[commit-bot: I haz the power, 2012-09-21 21:35:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/brianderson@chromium.org/10914304/18002

[commit-bot: I haz the power, 2012-09-21 21:35:29]

Presubmit check for 10914304-18002 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content/renderer/gpu

Missing LGTM from an OWNER for files in these directories:
    content/renderer/gpu

Presubmit checks took 2.4s to calculate.

[brianderson, 2012-09-21 21:48:32]

Adding OWNER apatrick for review of content/renderer/gpu/ changes.

[apatrick_chromium, 2012-09-26 01:10:11]

content/renderer/gpu LGTM

[commit-bot: I haz the power, 2012-09-26 21:54:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/brianderson@chromium.org/10914304/29002

[commit-bot: I haz the power, 2012-09-27 00:36:41]

Change committed as 158950