Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 10914236: cc: Avoid unnecessary destruction of texture update controller. (Closed)

Created:
8 years, 3 months ago by reveman
Modified:
8 years, 3 months ago
Reviewers:
jamesr, nduca
CC:
chromium-reviews
Visibility:
Public.

Description

cc: Avoid unnecessary destruction of texture update controller. GLES imlementation now handles this case properly and returns the correct value from glGetQueryObjectuivEXT when the context is lost. BUG= TEST=cc_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156623

Patch Set 1 #

Patch Set 2 : Update changelog #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M cc/CCLayerTreeHostTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCThreadProxy.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
reveman
Lets land this cleanup before https://bugs.webkit.org/show_bug.cgi?id=94721
8 years, 3 months ago (2012-09-12 19:42:47 UTC) #1
nduca
lgtm though the test change from 0 to 1 might deserve a minor comment in ...
8 years, 3 months ago (2012-09-12 19:52:41 UTC) #2
jamesr
lgtm. could you send out tryjobs, please? you can do that right from the codereview ...
8 years, 3 months ago (2012-09-12 19:55:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/10914236/4001
8 years, 3 months ago (2012-09-13 17:03:49 UTC) #4
commit-bot: I haz the power
8 years, 3 months ago (2012-09-13 20:33:17 UTC) #5
Change committed as 156623

Powered by Google App Engine
This is Rietveld 408576698