Issue 10913197: Convert throw from a statement to an expression (issue 4872)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10913197: Convert throw from a statement to an expression (issue 4872) (Closed)

Created:
8 years, 3 months ago by Brian Wilkerson

Modified:
8 years, 3 months ago

Reviewers:
messick, scheglov

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Convert throw from a statement to an expression (issue 4872) Committed: https://code.google.com/p/dart/source/detail?r=12212

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+74 lines, -99 lines)			Patch
M	compiler/java/com/google/dart/compiler/ast/ASTVisitor.java	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/ast/DartExprStmt.java	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/ast/DartPlainVisitor.java	View	1 chunk	+1 line, -1 line	0 comments	Download
D	compiler/java/com/google/dart/compiler/ast/DartThrowStatement.java	View	1 chunk	+0 lines, -36 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/ast/DartToSourceVisitor.java	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/CompletionHooksParserBase.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View	5 chunks	+17 lines, -8 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/DartASTValidator.java	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/ParserEventsTest.java	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/ParserRecoveryTest.java	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/AST.java	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/PropertyDescriptorHelper.java	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/PropertyGetter.java	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/PropertyLocator.java	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/PropertySetter.java	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/visitor/WrappedDartVisitorAdaptor.java	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionParser.java	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/dom/rewrite/ASTRewriteAnalyzer.java	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/formatter/CodeFormatterVisitor.java	View	4 chunks	+8 lines, -10 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/NodeClassifier.java	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/co19/co19-compiler.status	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages