editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/PropertySetter.java - Issue 10913197: Convert throw from a statement to an expression (issue 4872)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/PropertySetter.java

Issue 10913197: Convert throw from a statement to an expression (issue 4872) (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/PropertyLocator.java ('k') | editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/visitor/WrappedDartVisitorAdaptor.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/PropertySetter.java

===================================================================

--- editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/PropertySetter.java (revision 12211)

+++ editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/PropertySetter.java (working copy)

@@ -78,7 +78,7 @@

import com.google.dart.compiler.ast.DartSyntheticErrorExpression;

import com.google.dart.compiler.ast.DartSyntheticErrorStatement;

import com.google.dart.compiler.ast.DartThisExpression;

-import com.google.dart.compiler.ast.DartThrowStatement;

+import com.google.dart.compiler.ast.DartThrowExpression;

import com.google.dart.compiler.ast.DartTryStatement;

import com.google.dart.compiler.ast.DartTypeExpression;

import com.google.dart.compiler.ast.DartTypeNode;

@@ -853,11 +853,11 @@

}

@Override

- public Object visitThrowStatement(DartThrowStatement node) {

+ public Object visitThrowExpression(DartThrowExpression node) {

if (property == PropertyDescriptorHelper.DART_THROW_STATEMENT_EXCEPTION) {

// node.setException(propertyValue);

} else {

- visitStatement(node);

+ visitExpression(node);

}

DartCore.notYetImplemented();

return null;