chrome/browser/ui/views/external_protocol_dialog.h - Issue 1091253008: Fix an issue that external protocol in subframes are not handled on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/external_protocol_dialog.h

Issue 1091253008: Fix an issue that external protocol in subframes are not handled on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: adding isSubFrame to ExternalNavigationParams Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/external_protocol/external_protocol_handler.cc ('K') | « chrome/browser/ui/tab_helpers.cc ('k') | chrome/browser/ui/views/external_protocol_dialog.cc » ('j') | chrome/browser/ui/views/external_protocol_dialog.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/external_protocol_dialog.h

diff --git a/chrome/browser/ui/views/external_protocol_dialog.h b/chrome/browser/ui/views/external_protocol_dialog.h

index aa4bb9b043402602c65f5bfffba843af81700f80..9c6f78360abd94a01bd6cb8a8e991f9a2475a94f 100644

--- a/chrome/browser/ui/views/external_protocol_dialog.h

+++ b/chrome/browser/ui/views/external_protocol_dialog.h

@@ -22,7 +22,9 @@ class ExternalProtocolDialog : public views::DialogDelegate {

// RunExternalProtocolDialog calls this private constructor.

ExternalProtocolDialog(scoped_ptr<const ProtocolDialogDelegate> delegate,

int render_process_host_id,

- int routing_id);

+ int routing_id,

+ ui::PageTransition page_transition,

sky 2015/05/04 19:15:49 AFAICT page_transition and has_user_gesture aren't

qinmin 2015/05/04 19:31:52 ah.. I mistaken this for RunExternalProtocolDialog

+ bool has_user_gesture);

~ExternalProtocolDialog() override;