Fix an issue that external protocol in subframes are not handled on Android

chrome/browser/ui/views/external_protocol_dialog.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_EXTERNAL_PROTOCOL_DIALOG_H_
 #define CHROME_BROWSER_UI_VIEWS_EXTERNAL_PROTOCOL_DIALOG_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/time/time.h"
 #include "ui/views/window/dialog_delegate.h"
 #include "url/gurl.h"
 
 class ProtocolDialogDelegate;
 
 namespace views {
 class MessageBoxView;
 }
 
 class ExternalProtocolDialog : public views::DialogDelegate {
  public:
   // RunExternalProtocolDialog calls this private constructor.
   ExternalProtocolDialog(scoped_ptr<const ProtocolDialogDelegate> delegate,
                          int render_process_host_id,
-                         int routing_id);
+                         int routing_id,
+                         ui::PageTransition page_transition,

[sky, 2015/05/04 19:15:49]

AFAICT page_transition and has_user_gesture aren't needed. Why pass them in?

[qinmin, 2015/05/04 19:31:52]

ah.. I mistaken this for RunExternalProtocolDialog. Removed the params.

+                         bool has_user_gesture);
 
   ~ExternalProtocolDialog() override;
 
   // views::DialogDelegate methods:
   int GetDefaultDialogButton() const override;
   base::string16 GetDialogButtonLabel(ui::DialogButton button) const override;
   base::string16 GetWindowTitle() const override;
   void DeleteDelegate() override;
   bool Cancel() override;
   bool Accept() override;
@@ skipping 11 matching lines @@
   int render_process_host_id_;
   int routing_id_;
 
   // The time at which this dialog was created.
   base::TimeTicks creation_time_;
 
   DISALLOW_COPY_AND_ASSIGN(ExternalProtocolDialog);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_EXTERNAL_PROTOCOL_DIALOG_H_