chrome/browser/external_protocol/external_protocol_handler_unittest.cc - Issue 1091253008: Fix an issue that external protocol in subframes are not handled on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/external_protocol/external_protocol_handler_unittest.cc

Issue 1091253008: Fix an issue that external protocol in subframes are not handled on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: adding isSubFrame to ExternalNavigationParams Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/external_protocol/external_protocol_handler.cc ('K') | « chrome/browser/external_protocol/external_protocol_handler.cc ('k') | chrome/browser/prerender/prerender_browsertest.cc » ('j') | chrome/browser/ui/views/external_protocol_dialog.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/external_protocol/external_protocol_handler_unittest.cc

diff --git a/chrome/browser/external_protocol/external_protocol_handler_unittest.cc b/chrome/browser/external_protocol/external_protocol_handler_unittest.cc

index 1aac925915287ac0527a9c2e69d0c17390f8c694..2aa69559dfb2121763fb11fd4fcc6bcb71eb160d 100644

--- a/chrome/browser/external_protocol/external_protocol_handler_unittest.cc

+++ b/chrome/browser/external_protocol/external_protocol_handler_unittest.cc

@@ -40,7 +40,7 @@ class FakeExternalProtocolHandlerDelegate

os_state_(ShellIntegration::UNKNOWN_DEFAULT),

has_launched_(false),

has_prompted_(false),

- has_blocked_ (false) {}

+ has_blocked_(false) {}

ShellIntegration::DefaultProtocolClientWorker* CreateShellWorker(

ShellIntegration::DefaultWebClientObserver* observer,

@@ -61,7 +61,10 @@ class FakeExternalProtocolHandlerDelegate

void RunExternalProtocolDialog(const GURL& url,

int render_process_host_id,

- int routing_id) override {

+ int routing_id,

+ bool is_main_frame,

+ ui::PageTransition page_transition,

+ bool has_user_gesture) override {

ASSERT_EQ(block_state_, ExternalProtocolHandler::UNKNOWN);

ASSERT_NE(os_state_, ShellIntegration::IS_DEFAULT);

has_prompted_ = true;