components/navigation_interception/intercept_navigation_resource_throttle.cc - Issue 1091253008: Fix an issue that external protocol in subframes are not handled on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/navigation_interception/intercept_navigation_resource_throttle.cc

Issue 1091253008: Fix an issue that external protocol in subframes are not handled on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase and fix test Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/tab_helpers.cc ('K') | « components/navigation_interception/android/java/src/org/chromium/components/navigation_interception/NavigationParams.java ('k') | components/navigation_interception/navigation_params.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/navigation_interception/intercept_navigation_resource_throttle.cc

diff --git a/components/navigation_interception/intercept_navigation_resource_throttle.cc b/components/navigation_interception/intercept_navigation_resource_throttle.cc

index 05741e65c2101bdc3219ac6933cf1fbf47d32b5a..1b0b89f43d396926c777878c2cf92179ed2e61e6 100644

--- a/components/navigation_interception/intercept_navigation_resource_throttle.cc

+++ b/components/navigation_interception/intercept_navigation_resource_throttle.cc

@@ -112,7 +112,7 @@ bool InterceptNavigationResourceThrottle::CheckIfShouldIgnoreNavigation(

Referrer::SanitizeForRequest(

url, Referrer(GURL(request_->referrer()), info->GetReferrerPolicy())),

info->HasUserGesture(), method == "POST", info->GetPageTransition(),

- is_redirect, is_external_protocol);

+ is_redirect, is_external_protocol, true);

BrowserThread::PostTask(

BrowserThread::UI,