Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: components/navigation_interception/android/java/src/org/chromium/components/navigation_interception/NavigationParams.java

Issue 1091253008: Fix an issue that external protocol in subframes are not handled on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase and fix test Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/navigation_interception/android/java/src/org/chromium/components/navigation_interception/NavigationParams.java
diff --git a/components/navigation_interception/android/java/src/org/chromium/components/navigation_interception/NavigationParams.java b/components/navigation_interception/android/java/src/org/chromium/components/navigation_interception/NavigationParams.java
index 3832676d9e3d6e6441ffa68fb356b5563445757c..4bd91c63db2060aa74556b4dfce9b0eb1d1f6027 100644
--- a/components/navigation_interception/android/java/src/org/chromium/components/navigation_interception/NavigationParams.java
+++ b/components/navigation_interception/android/java/src/org/chromium/components/navigation_interception/NavigationParams.java
@@ -21,24 +21,27 @@ public class NavigationParams {
public final boolean isExternalProtocol;
// True if the navigation was orignated from a navigation which had been initiated by the user.
public final boolean hasUserGestureCarryover;
+ // True if the navigation was originated from the main frame.
+ public final boolean isMainFrame;
public NavigationParams(String url, boolean isPost, boolean hasUserGesture,
int pageTransitionType, boolean isRedirect, boolean isExternalProtocol,
- boolean hasUserGestureCarryover) {
+ boolean isMainFrame, boolean hasUserGestureCarryover) {
this.url = url;
this.isPost = isPost;
this.hasUserGesture = hasUserGesture;
this.pageTransitionType = pageTransitionType;
this.isRedirect = isRedirect;
this.isExternalProtocol = isExternalProtocol;
+ this.isMainFrame = isMainFrame;
this.hasUserGestureCarryover = hasUserGestureCarryover;
}
@CalledByNative
public static NavigationParams create(String url, boolean isPost, boolean hasUserGesture,
int pageTransitionType, boolean isRedirect, boolean isExternalProtocol,
- boolean hasUserGestureCarryover) {
+ boolean isMainFrame, boolean hasUserGestureCarryover) {
return new NavigationParams(url, isPost, hasUserGesture, pageTransitionType, isRedirect,
- isExternalProtocol, hasUserGestureCarryover);
+ isExternalProtocol, isMainFrame, hasUserGestureCarryover);
}
}

Powered by Google App Engine
This is Rietveld 408576698