chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h - Issue 1091253008: Fix an issue that external protocol in subframes are not handled on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h

Issue 1091253008: Fix an issue that external protocol in subframes are not handled on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase and fix test Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/prerender/prerender_browsertest.cc ('k') | chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc » ('j') | chrome/browser/ui/tab_helpers.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h

diff --git a/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h b/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h

index ffbab62156f21869933b249cc54c71cbd93ca841..b0d6f34a03766458b44c5600e588b2c255a70cce 100644

--- a/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h

+++ b/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h

@@ -54,7 +54,10 @@ class ChromeResourceDispatcherHostDelegate

net::URLRequest* request) override;

bool HandleExternalProtocol(const GURL& url,

int child_id,

- int route_id) override;

+ int route_id,

+ bool is_main_frame,

+ ui::PageTransition page_transition,

+ bool has_user_gesture) override;

bool ShouldForceDownloadResource(const GURL& url,

const std::string& mime_type) override;

bool ShouldInterceptResourceAsStream(net::URLRequest* request,