Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: chrome/browser/prerender/prerender_browsertest.cc

Issue 1091253008: Fix an issue that external protocol in subframes are not handled on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase and fix test Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_browsertest.cc
diff --git a/chrome/browser/prerender/prerender_browsertest.cc b/chrome/browser/prerender/prerender_browsertest.cc
index 9aca6168b525e7a43cac4cc900116923cb071ec7..9009afd634018b082d83e76ccf773994a7726ccb 100644
--- a/chrome/browser/prerender/prerender_browsertest.cc
+++ b/chrome/browser/prerender/prerender_browsertest.cc
@@ -1056,7 +1056,9 @@ class NeverRunsExternalProtocolHandlerDelegate
void BlockRequest() override {}
void RunExternalProtocolDialog(const GURL& url,
int render_process_host_id,
- int routing_id) override {
+ int routing_id,
+ ui::PageTransition page_transition,
+ bool has_user_gesture) override {
NOTREACHED();
}
void LaunchUrlWithoutSecurityCheck(const GURL& url) override { NOTREACHED(); }

Powered by Google App Engine
This is Rietveld 408576698