android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc - Issue 1091253008: Fix an issue that external protocol in subframes are not handled on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc

Issue 1091253008: Fix an issue that external protocol in subframes are not handled on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase and fix test Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.h ('k') | chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java » ('j') | chrome/browser/ui/tab_helpers.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc

diff --git a/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc b/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc

index 82b1e08866c930cfcb0e2ff0501b9b0101750832..02160ce9f13534c9343f7e79c147ebea1f3a7f43 100644

--- a/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc

+++ b/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc

@@ -316,9 +316,13 @@ content::ResourceDispatcherHostLoginDelegate*

return new AwLoginDelegate(auth_info, request);

}

-bool AwResourceDispatcherHostDelegate::HandleExternalProtocol(const GURL& url,

- int child_id,

- int route_id) {

+bool AwResourceDispatcherHostDelegate::HandleExternalProtocol(

+ const GURL& url,

+ int child_id,

+ int route_id,

+ bool is_main_frame,

+ ui::PageTransition page_transition,

+ bool has_user_gesture) {

// The AwURLRequestJobFactory implementation should ensure this method never

// gets called.

NOTREACHED();