Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Side by Side Diff: android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc

Issue 1091253008: Fix an issue that external protocol in subframes are not handled on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase and fix test Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/browser/renderer_host/aw_resource_dispatcher_host_dele gate.h" 5 #include "android_webview/browser/renderer_host/aw_resource_dispatcher_host_dele gate.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "android_webview/browser/aw_contents_io_thread_client.h" 9 #include "android_webview/browser/aw_contents_io_thread_client.h"
10 #include "android_webview/browser/aw_login_delegate.h" 10 #include "android_webview/browser/aw_login_delegate.h"
(...skipping 298 matching lines...) Expand 10 before | Expand all | Expand 10 after
309 } 309 }
310 } 310 }
311 311
312 content::ResourceDispatcherHostLoginDelegate* 312 content::ResourceDispatcherHostLoginDelegate*
313 AwResourceDispatcherHostDelegate::CreateLoginDelegate( 313 AwResourceDispatcherHostDelegate::CreateLoginDelegate(
314 net::AuthChallengeInfo* auth_info, 314 net::AuthChallengeInfo* auth_info,
315 net::URLRequest* request) { 315 net::URLRequest* request) {
316 return new AwLoginDelegate(auth_info, request); 316 return new AwLoginDelegate(auth_info, request);
317 } 317 }
318 318
319 bool AwResourceDispatcherHostDelegate::HandleExternalProtocol(const GURL& url, 319 bool AwResourceDispatcherHostDelegate::HandleExternalProtocol(
320 int child_id, 320 const GURL& url,
321 int route_id) { 321 int child_id,
322 int route_id,
323 bool is_main_frame,
324 ui::PageTransition page_transition,
325 bool has_user_gesture) {
322 // The AwURLRequestJobFactory implementation should ensure this method never 326 // The AwURLRequestJobFactory implementation should ensure this method never
323 // gets called. 327 // gets called.
324 NOTREACHED(); 328 NOTREACHED();
325 return false; 329 return false;
326 } 330 }
327 331
328 void AwResourceDispatcherHostDelegate::OnResponseStarted( 332 void AwResourceDispatcherHostDelegate::OnResponseStarted(
329 net::URLRequest* request, 333 net::URLRequest* request,
330 content::ResourceContext* resource_context, 334 content::ResourceContext* resource_context,
331 content::ResourceResponse* response, 335 content::ResourceResponse* response,
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
439 net::HttpRequestHeaders headers; 443 net::HttpRequestHeaders headers;
440 headers.AddHeadersFromString(extra_headers); 444 headers.AddHeadersFromString(extra_headers);
441 for (net::HttpRequestHeaders::Iterator it(headers); it.GetNext(); ) { 445 for (net::HttpRequestHeaders::Iterator it(headers); it.GetNext(); ) {
442 request->SetExtraRequestHeaderByName(it.name(), it.value(), false); 446 request->SetExtraRequestHeaderByName(it.name(), it.value(), false);
443 } 447 }
444 } 448 }
445 } 449 }
446 } 450 }
447 451
448 } // namespace android_webview 452 } // namespace android_webview
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698