Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Unified Diff: extensions/browser/guest_view/mime_handler_view/mime_handler_view_browsertest.cc

Issue 1091253004: Fix MimeHandlerView plugin loading for data: URLs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/mime_handler_view/mime_handler_view_browsertest.cc
diff --git a/extensions/browser/guest_view/mime_handler_view/mime_handler_view_browsertest.cc b/extensions/browser/guest_view/mime_handler_view/mime_handler_view_browsertest.cc
index 5b09caf3beeb4e9ff1b914dcf032c1b4b662fedb..7db592c10922b7346e25b12edb8fdc9ff6d6f53c 100644
--- a/extensions/browser/guest_view/mime_handler_view/mime_handler_view_browsertest.cc
+++ b/extensions/browser/guest_view/mime_handler_view/mime_handler_view_browsertest.cc
@@ -30,22 +30,24 @@ class MimeHandlerViewTest : public ExtensionApiTest {
return extension;
}
- void RunTest(const std::string& path) {
+ void RunTestWithUrl(const GURL& url) {
const extensions::Extension* extension = LoadTestExtension();
ASSERT_TRUE(extension);
- ASSERT_TRUE(StartEmbeddedTestServer());
- embedded_test_server()->ServeFilesFromDirectory(
- test_data_dir_.AppendASCII("mime_handler_view"));
-
extensions::ResultCatcher catcher;
-
- ui_test_utils::NavigateToURL(browser(),
- embedded_test_server()->GetURL("/" + path));
+ ui_test_utils::NavigateToURL(browser(), url);
if (!catcher.GetNextResult())
FAIL() << catcher.message();
}
+
+ void RunTest(const std::string& path) {
+ ASSERT_TRUE(StartEmbeddedTestServer());
+ embedded_test_server()->ServeFilesFromDirectory(
+ test_data_dir_.AppendASCII("mime_handler_view"));
+
+ RunTestWithUrl(embedded_test_server()->GetURL("/" + path));
+ }
};
IN_PROC_BROWSER_TEST_F(MimeHandlerViewTest, PostMessage) {
@@ -67,3 +69,12 @@ IN_PROC_BROWSER_TEST_F(MimeHandlerViewTest, Iframe) {
IN_PROC_BROWSER_TEST_F(MimeHandlerViewTest, Abort) {
RunTest("testAbort.csv");
}
+
+IN_PROC_BROWSER_TEST_F(MimeHandlerViewTest, DataUrl) {
+ const char* kDataUrlCsv = "data:text/csv;base64,Y29udGVudCB0byByZWFkCg==";
Sam McNally 2015/04/22 04:05:03 Would this navigation have bypassed the browser pr
raymes 2015/04/22 04:11:48 No, this one would have worked. The one below woul
+ RunTestWithUrl(GURL(kDataUrlCsv));
+}
+
+IN_PROC_BROWSER_TEST_F(MimeHandlerViewTest, EmbeddedDataUrl) {
+ RunTest("test_embedded_data_url.html");
+}
« content/child/web_url_loader_impl.cc ('K') | « content/child/web_url_loader_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698