Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Unified Diff: content/child/web_url_loader_impl.cc

Issue 1091253004: Fix MimeHandlerView plugin loading for data: URLs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/web_url_loader_impl.cc
diff --git a/content/child/web_url_loader_impl.cc b/content/child/web_url_loader_impl.cc
index c3431b5649d5b4c78ccd81b817636e861b7b3d6d..a1a5beb4b281d6f4a625d33b26f497db68b30b81 100644
--- a/content/child/web_url_loader_impl.cc
+++ b/content/child/web_url_loader_impl.cc
@@ -778,6 +778,11 @@ bool WebURLLoaderImpl::Context::CanHandleDataURLRequestLocally() const {
if (request_.downloadToFile())
return false;
+ // Data url requests from object tags may need to be intercepted as streams
+ // and so need to be sent to the browser.
+ if (request_.requestContext() == WebURLRequest::RequestContextObject)
Sam McNally 2015/04/22 04:05:03 What about WebURLRequest::RequestContextEmbed?
raymes 2015/04/22 04:11:48 It's not used for MimeHandlers so we don't need to
+ return false;
+
// Optimize for the case where we can handle a data URL locally. We must
// skip this for data URLs targetted at frames since those could trigger a
// download.

Powered by Google App Engine
This is Rietveld 408576698