Using API keys for requests to Chrome Web Store.

Using API keys for requests to Chrome Web Store.


BUG=148801
R=gbillock@chromium.org for Web Intents changes.

R=joi@chromium.org to verify that I am using GetAPIKey() correctly.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157197

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157393

[Jói, 2012-09-17 16:56:19]

LGTM

https://codereview.chromium.org/10911331/diff/1/chrome/browser/intents/cws_in...
File chrome/browser/intents/cws_intents_registry.cc (right):

https://codereview.chromium.org/10911331/diff/1/chrome/browser/intents/cws_in...
chrome/browser/intents/cws_intents_registry.cc:22: // Forward declaration.
Seems simpler to just #include (and update DEPS if needed) but totally up to you
if you prefer to do it this way.

[Steve McKay, 2012-09-17 17:01:43]

Inline Q for Jói.

https://codereview.chromium.org/10911331/diff/1/chrome/browser/intents/cws_in...
File chrome/browser/intents/cws_intents_registry.cc (right):

https://codereview.chromium.org/10911331/diff/1/chrome/browser/intents/cws_in...
chrome/browser/intents/cws_intents_registry.cc:241: google_apis::GetAPIKey());
Question, for Jói mostly. In the past when we needed to see actual suggestions
from the chrome web store in the picker we would add a real key to our api_key
file (and not check in).  With the new "GetAPIKey" call, will it return a useful
key allowing results to be returned, or will that only happen in release builds?

[Jói, 2012-09-17 17:05:20]

If you follow the instructions at
http://www.chromium.org/developers/how-tos/api-keys to acquire and set
up keys, then yes, it will return a useful key.

Cheers,
Jói


On Mon, Sep 17, 2012 at 5:01 PM,  <smckay@chromium.org> wrote:
> Inline Q for Jói.
>
>
>
>
https://codereview.chromium.org/10911331/diff/1/chrome/browser/intents/cws_in...
> File chrome/browser/intents/cws_intents_registry.cc (right):
>
>
https://codereview.chromium.org/10911331/diff/1/chrome/browser/intents/cws_in...
> chrome/browser/intents/cws_intents_registry.cc:241:
> google_apis::GetAPIKey());
> Question, for Jói mostly. In the past when we needed to see actual
> suggestions from the chrome web store in the picker we would add a real
> key to our api_key file (and not check in).  With the new "GetAPIKey"
> call, will it return a useful key allowing results to be returned, or
> will that only happen in release builds?
>
> https://codereview.chromium.org/10911331/

[please use gerrit instead, 2012-09-17 17:25:38]

Adding gbillock@ to the list of reviewers.

[Greg Billock, 2012-09-17 17:52:18]

https://codereview.chromium.org/10911331/diff/1/chrome/browser/intents/cws_in...
File chrome/browser/intents/cws_intents_registry.cc (right):

https://codereview.chromium.org/10911331/diff/1/chrome/browser/intents/cws_in...
chrome/browser/intents/cws_intents_registry.cc:22: // Forward declaration.
On 2012/09/17 16:56:19, Jói wrote:
> Seems simpler to just #include (and update DEPS if needed) but totally up to
you
> if you prefer to do it this way.

Yes, let's #include

[please use gerrit instead, 2012-09-17 18:07:08]

On 2012/09/17 17:52:18, Greg Billock wrote:
> let's #include

Done.

[Greg Billock, 2012-09-17 18:08:30]

On 2012/09/17 18:07:08, Rouslan Solomakhin wrote:
> On 2012/09/17 17:52:18, Greg Billock wrote:
> > let's #include
> 
> Done.

lgtm

[commit-bot: I haz the power, 2012-09-17 18:08:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rouslan@chromium.org/10911331/9002

[commit-bot: I haz the power, 2012-09-17 18:08:45]

Presubmit check for 10911331-9002 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

[James Hawkins, 2012-09-17 18:30:45]

lgtm

[commit-bot: I haz the power, 2012-09-17 18:34:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rouslan@chromium.org/10911331/9002

[commit-bot: I haz the power, 2012-09-17 20:54:07]

Change committed as 157197

[commit-bot: I haz the power, 2012-09-18 16:38:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rouslan@chromium.org/10911331/16001

[commit-bot: I haz the power, 2012-09-18 19:05:16]

Change committed as 157393