Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1091093002: Partial revert of disabling low latency audio for remote desktop. (Closed)

Created:
5 years, 8 months ago by DaleCurtis
Modified:
5 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Partial revert of disabling low latency audio for remote desktop. Crash and playback startup success rates remained the same before and after this change, so reverting the additional complexity. I've left the cleanup of internal functions though. BUG=422522 TEST=things work as before. Committed: https://crrev.com/933778ccbfaa26fc859f43da2f98eba966082e34 Cr-Commit-Position: refs/heads/master@{#325577}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -57 lines) Patch
M media/audio/win/audio_low_latency_output_win.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M media/audio/win/core_audio_util_win.h View 1 chunk +0 lines, -3 lines 0 comments Download
M media/audio/win/core_audio_util_win.cc View 3 chunks +1 line, -49 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
DaleCurtis
No help with this stuff :( exploring STA change now.
5 years, 8 months ago (2015-04-16 18:43:57 UTC) #2
henrika (OOO until Aug 14)
LGTM
5 years, 8 months ago (2015-04-16 18:45:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1091093002/1
5 years, 8 months ago (2015-04-16 21:50:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-17 01:56:49 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 01:58:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/933778ccbfaa26fc859f43da2f98eba966082e34
Cr-Commit-Position: refs/heads/master@{#325577}

Powered by Google App Engine
This is Rietveld 408576698