chrome/common/extensions/api/app_window.idl - Issue 10910304: Cache the object given to the chrome.app.window.create callback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/app_window.idl

Issue 10910304: Cache the object given to the chrome.app.window.create callback (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: first round of comments Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/renderer/resources/extensions/app_window_custom_bindings.js » ('j') | chrome/renderer/resources/extensions/app_window_custom_bindings.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/app_window.idl

diff --git a/chrome/common/extensions/api/app_window.idl b/chrome/common/extensions/api/app_window.idl

index 9dca0a3706de6a2dcc08a942cbf6afbb63897e63..5aac989e1d4ffd19a69067d049639d2b4e4effcb 100644

--- a/chrome/common/extensions/api/app_window.idl

+++ b/chrome/common/extensions/api/app_window.idl

@@ -109,5 +109,6 @@ namespace app.window {

optional CreateWindowCallback callback);

[nocompile] static AppWindow current();

+ [internal, nocompile] static void makeAppWindow(object state);

jeremya 2012/09/17 17:46:58 I don't think you really need to list this in the

tapted 2012/09/18 04:17:24 I seem to get errors if I remove it, along the lin

};