Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: chrome/common/extensions/api/app_window.idl

Issue 10910304: Cache the object given to the chrome.app.window.create callback (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: first round of comments Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 namespace app.window { 5 namespace app.window {
6 dictionary CreateWindowOptions { 6 dictionary CreateWindowOptions {
7 // Id to identify the window. This will be used to remember the size 7 // Id to identify the window. This will be used to remember the size
8 // and position of the window and restore that geometry when a window 8 // and position of the window and restore that geometry when a window
9 // with the same id (and no explicit size or position) is later opened. 9 // with the same id (and no explicit size or position) is later opened.
10 DOMString? id; 10 DOMString? id;
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 // coordinate, you should also specify a left (or top) coordinate, and 102 // coordinate, you should also specify a left (or top) coordinate, and
103 // similar for size. 103 // similar for size.
104 // 104 //
105 // If you specify both a regular and a default value for the same option 105 // If you specify both a regular and a default value for the same option
106 // the regular value is the only one that takes effect. 106 // the regular value is the only one that takes effect.
107 static void create(DOMString url, 107 static void create(DOMString url,
108 optional CreateWindowOptions options, 108 optional CreateWindowOptions options,
109 optional CreateWindowCallback callback); 109 optional CreateWindowCallback callback);
110 110
111 [nocompile] static AppWindow current(); 111 [nocompile] static AppWindow current();
112 [internal, nocompile] static void makeAppWindow(object state);
jeremya 2012/09/17 17:46:58 I don't think you really need to list this in the
tapted 2012/09/18 04:17:24 I seem to get errors if I remove it, along the lin
112 }; 113 };
113 }; 114 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698