lib/core/regexp.dart - Issue 10910253: Change RegExp constructor to insist on proper named optional parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/core/regexp.dart

Issue 10910253: Change RegExp constructor to insist on proper named optional parameters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Update co19/dart2js status. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/core/regexp.dart

diff --git a/lib/core/regexp.dart b/lib/core/regexp.dart

index 1cf4a9783ad497296d26bfdeedc62ad568835ed1..a301785095ba48183e203b9d7c683bf3f66e7fdc 100644

--- a/lib/core/regexp.dart

+++ b/lib/core/regexp.dart

@@ -89,7 +89,7 @@ interface RegExp extends Pattern default JSSyntaxRegExp {

* Constructs a regular expression. The default implementation of a

* [RegExp] sets [multiLine] and [ignoreCase] to false.

- const RegExp(String pattern, [bool multiLine, bool ignoreCase]);

+ const RegExp(String pattern, {bool multiLine, bool ignoreCase});

/**

* Searches for the first match of the regular expression

« no previous file with comments | « lib/compiler/implementation/lib/string_helper.dart ('k') | pkg/dartdoc/inline_parser.dart » ('j') | no next file with comments »