Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Unified Diff: runtime/vm/intermediate_language.h

Issue 10910252: Improve register usage for StoreInstanceField. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Addressed comment and improved StoreIndexed as well. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.h
===================================================================
--- runtime/vm/intermediate_language.h (revision 12307)
+++ runtime/vm/intermediate_language.h (working copy)
@@ -2155,8 +2155,8 @@
Value* instance() const { return inputs_[0]; }
Value* value() const { return inputs_[1]; }
- bool emit_store_barrier() const {
- return emit_store_barrier_;
+ bool ShouldEmitStoreBarrier() const {
+ return value()->NeedsStoreBuffer() && emit_store_barrier_;
}
virtual void PrintOperandsTo(BufferFormatter* f) const;
@@ -2265,7 +2265,9 @@
Value* index() const { return inputs_[1]; }
Value* value() const { return inputs_[2]; }
- bool emit_store_barrier() const { return emit_store_barrier_; }
+ bool ShouldEmitStoreBarrier() const {
+ return value()->NeedsStoreBuffer() && emit_store_barrier_;
+ }
virtual bool CanDeoptimize() const { return false; }
virtual intptr_t ResultCid() const { return kDynamicCid; }
« no previous file with comments | « runtime/vm/flow_graph_compiler.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698