Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/flow_graph_compiler.cc

Issue 10910252: Improve register usage for StoreInstanceField. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Addressed comment and improved StoreIndexed as well. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/intermediate_language.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler.cc
===================================================================
--- runtime/vm/flow_graph_compiler.cc (revision 12307)
+++ runtime/vm/flow_graph_compiler.cc (working copy)
@@ -660,12 +660,14 @@
Register reg = kNoRegister;
if (loc.IsRegister()) {
reg = loc.reg();
- } else if (loc.IsUnallocated()) {
- ASSERT((loc.policy() == Location::kRequiresRegister) ||
- (loc.policy() == Location::kWritableRegister));
+ } else if (loc.IsUnallocated() || loc.IsConstant()) {
+ ASSERT(loc.IsConstant() ||
+ ((loc.policy() == Location::kRequiresRegister) ||
+ (loc.policy() == Location::kWritableRegister)));
reg = AllocateFreeRegister(blocked_registers);
locs->set_in(i, Location::RegisterLocation(reg));
}
+ ASSERT(reg != kNoRegister);
// Inputs are consumed from the simulated frame. In case of a call argument
// we leave it until the call instruction.
« no previous file with comments | « no previous file | runtime/vm/intermediate_language.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698