Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 1090993002: Remove four libcxx known failures now that mkstemp/get_temp_file_name works. (Closed)

Created:
5 years, 8 months ago by jvoung (off chromium)
Modified:
5 years, 8 months ago
Reviewers:
Derek Schuff, JF
CC:
native-client-reviews_googlegroups.com, Sam Clegg, JF
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

An update on four libcxx known failures now that mkstemp/get_temp_file_name works. make: *** [check-libcxx] Error 2 4773 tests, 71 failures Parsed /mnt/data/b/build/slave/nacl-toolchain/build/native_client/pnacl/scripts/libcxx_known_failures.txt: now 75 total excludes libc++::input.output/file.streams/fstreams/fstream.assign/member_swap.pass.cpp: unexpected success libc++::input.output/file.streams/fstreams/ofstream.assign/member_swap.pass.cpp: unexpected success libc++::input.output/file.streams/fstreams/fstream.assign/nonmember_swap.pass.cpp: unexpected success libc++::input.output/file.streams/fstreams/ofstream.assign/nonmember_swap.pass.cpp: unexpected success 0 unexpected failures 4 unexpected passes BUG=none (red FYI bot). R=jfb@chromium.org Committed: https://chromium.googlesource.com/native_client/src/native_client/+/d88fa4fed707a60fd29ef9d382ca030818d115a1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M pnacl/scripts/libcxx_known_failures.txt View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jvoung (off chromium)
5 years, 8 months ago (2015-04-16 15:51:15 UTC) #2
JF
lgtm
5 years, 8 months ago (2015-04-16 15:55:21 UTC) #4
jvoung (off chromium)
5 years, 8 months ago (2015-04-16 16:07:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d88fa4fed707a60fd29ef9d382ca030818d115a1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698