Issue 1090943003: Skip OWNERS checks for CQ dry runs

Issue 1090943003: Skip OWNERS checks for CQ dry runs (Closed)

Created:
5 years, 8 months ago by rmistry

Modified:
4 years, 7 months ago

Reviewers:
Dirk Pranke, eclipse0072015

CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Target Ref:
refs/heads/master

Project:
tools

Visibility:
Public.

Skip OWNERS checks for CQ dry runs The CQ dry run feature was announced in https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/G5-X0_tfmok The primary complain is that the presubmit builders fail because of OWNERS checks or because of "Missing LGTM from someone other than...". This change skips those checks for dry runs. BUG=chromium:477190 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294853

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -14 lines)			Patch
	M	presubmit_canned_checks.py	View		1 chunk	+5 lines, -1 line	0 comments	Download
	M	tests/presubmit_unittest.py	View	1 2	4 chunks	+36 lines, -13 lines	0 comments	Download

Total messages: 13 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1090943003/40001

5 years, 8 months ago (2015-04-16 16:34:58 UTC) #5

commit-bot: I haz the power

Committed patchset #3 (id:40001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=294853

5 years, 8 months ago (2015-04-16 16:38:45 UTC) #6

eclipse0072015

On 2016/04/23 10:23:16, eclipse0072015 wrote: > lgtm d

4 years, 8 months ago (2016-04-23 10:34:21 UTC) #10

eclipse0072015

On 2016/04/23 10:34:21, eclipse0072015 wrote: > On 2016/04/23 10:23:16, eclipse0072015 wrote: > > lgtm > ...

4 years, 7 months ago (2016-04-27 18:14:48 UTC) #11

eclipse0072015

On 2015/04/16 16:28:39, Dirk Pranke wrote: > lgtm h

4 years, 7 months ago (2016-04-27 18:32:10 UTC) #12

eclipse0072015

4 years, 7 months ago (2016-04-27 18:32:37 UTC) #13

Message was sent while issue was closed.

On 2015/04/16 16:28:39, Dirk Pranke wrote:
> lgtm

uu